Try tracking deferred nodes using arrays

[DanielRosenwasser]

Experimenting with results I found from #46595 (specifically b7d31bc)

[DanielRosenwasser]

@typescript-bot perf test this faster

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at ab686d8. You can monitor the build here.

Update: The results are in!

[DanielRosenwasser]

Aside: why don't we deallocate these deferred node sets when we're done with type-checking the file? They become effectively unreachable.

[typescript-bot]

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52605

Metric	main	52605	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	359,220k (± 0.01%)	359,645k (± 0.01%)	+425k (+ 0.12%)	359,618k	359,714k	p=0.005 n=6
Parse Time	4.18s (± 0.38%)	4.20s (± 0.33%)	~	4.18s	4.22s	p=0.118 n=6
Bind Time	1.23s (± 0.00%)	1.22s (± 0.68%)	~	1.21s	1.23s	p=0.176 n=6
Check Time	9.47s (± 0.31%)	9.49s (± 0.47%)	~	9.45s	9.56s	p=0.517 n=6
Emit Time	8.05s (± 0.16%)	8.10s (± 0.62%)	~	8.04s	8.18s	p=0.076 n=6
Total Time	22.93s (± 0.09%)	23.01s (± 0.37%)	~	22.88s	23.13s	p=0.077 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	193,990k (± 0.03%)	195,154k (± 0.90%)	~	193,921k	197,524k	p=0.173 n=6
Parse Time	1.80s (± 0.46%)	1.82s (± 0.45%)	+0.01s (+ 0.65%)	1.81s	1.83s	p=0.045 n=6
Bind Time	0.85s (± 0.48%)	0.85s (± 0.48%)	~	0.84s	0.85s	p=1.000 n=6
Check Time	10.45s (± 0.81%)	10.49s (± 0.53%)	~	10.45s	10.60s	p=0.108 n=6
Emit Time	3.06s (± 0.96%)	3.06s (± 0.54%)	~	3.03s	3.08s	p=0.466 n=6
Total Time	16.17s (± 0.54%)	16.21s (± 0.38%)	~	16.14s	16.32s	p=0.261 n=6
Monaco - node (v16.17.1, x64)
Memory used	343,278k (± 0.01%)	343,458k (± 0.01%)	+180k (+ 0.05%)	343,429k	343,500k	p=0.005 n=6
Parse Time	3.15s (± 1.13%)	3.16s (± 1.12%)	~	3.10s	3.20s	p=0.466 n=6
Bind Time	1.12s (± 0.56%)	1.12s (± 0.49%)	~	1.11s	1.12s	p=0.201 n=6
Check Time	7.72s (± 0.31%)	7.76s (± 0.30%)	+0.04s (+ 0.56%)	7.72s	7.79s	p=0.019 n=6
Emit Time	4.53s (± 0.61%)	4.53s (± 0.54%)	~	4.50s	4.55s	p=1.000 n=6
Total Time	16.52s (± 0.30%)	16.57s (± 0.46%)	~	16.44s	16.65s	p=0.199 n=6
TFS - node (v16.17.1, x64)
Memory used	299,769k (± 0.01%)	299,913k (± 0.01%)	+145k (+ 0.05%)	299,894k	299,947k	p=0.005 n=6
Parse Time	2.49s (± 2.15%)	2.48s (± 1.55%)	~	2.45s	2.55s	p=0.747 n=6
Bind Time	1.26s (± 0.41%)	1.25s (± 0.67%)	~	1.24s	1.26s	p=0.923 n=6
Check Time	7.21s (± 0.47%)	7.20s (± 0.29%)	~	7.18s	7.24s	p=1.000 n=6
Emit Time	4.23s (± 0.86%)	4.20s (± 0.59%)	~	4.18s	4.25s	p=0.220 n=6
Total Time	15.18s (± 0.75%)	15.13s (± 0.31%)	~	15.08s	15.20s	p=0.689 n=6
material-ui - node (v16.17.1, x64)
Memory used	476,134k (± 0.01%)	476,373k (± 0.01%)	+239k (+ 0.05%)	476,344k	476,420k	p=0.005 n=6
Parse Time	3.71s (± 0.24%)	3.72s (± 0.20%)	~	3.71s	3.73s	p=0.149 n=6
Bind Time	1.02s (± 0.00%)	1.02s (± 0.40%)	~	1.02s	1.03s	p=0.405 n=6
Check Time	18.13s (± 0.23%)	18.18s (± 0.17%)	~	18.13s	18.22s	p=0.126 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.86s (± 0.17%)	22.92s (± 0.14%)	+0.06s (+ 0.26%)	22.87s	22.96s	p=0.030 n=6
xstate - node (v16.17.1, x64)
Memory used	546,762k (± 0.02%)	546,851k (± 0.03%)	~	546,678k	547,096k	p=0.378 n=6
Parse Time	4.75s (± 0.35%)	4.77s (± 0.41%)	~	4.73s	4.78s	p=0.256 n=6
Bind Time	1.81s (± 3.98%)	1.78s (± 5.08%)	~	1.66s	1.85s	p=1.000 n=6
Check Time	3.08s (± 3.26%)	3.13s (± 2.88%)	~	3.04s	3.26s	p=0.336 n=6
Emit Time	0.09s (± 4.45%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=0.405 n=6
Total Time	9.74s (± 0.56%)	9.77s (± 0.26%)	~	9.74s	9.80s	p=0.334 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	52605	6
Baseline	main	6

Developer Information:

Download Benchmark

[DanielRosenwasser]

lol

[sandersn]

@DanielRosenwasser this looks like it didn't help at the time and is even less likely to help if applied to Corsa. I vote that we close it.