fix(30003): formatter deletes comment after trailing comma (again) #49168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30003 again.
As I mentioned in #30003 (comment), the original fix, PR #36674, only checks for cases where the trailing comma is on the same line as
(
, failing on cases likeThe problem originates from that when the
NoSpaceBeforeCloseParen
rule was applied, the relevant tokens were5
and)
, making the rule treat everything in between as whitespace to be deleted. This happened because the comma was onlyadvance
'd over, not consumed, so not recorded:TypeScript/src/services/formatting/formatting.ts
Lines 836 to 844 in ce85d64
This PR tries to fix the problem by
consumeTokenAndAdvanceScanner
'ing the comma instead ofadvance
ing over it.