fix(49151): formatter wrongly indent '>' after type parameters/arguments #49165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the formatter did not consider these constructs as comma separated lists in general, leading to wrong indentation of '>' after the list.
|
|
typescript-bot
added
the
For Uncommitted Bug
|
I think you merge-conflicted with yourself in #49168 😄 |
|
Weird since the PRs actually modify different lines. This one removes the call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49151
Before, the formatter did not consider type parameters/arguments in general as comma
separated lists, leading to wrong indentation of
>after them, such as in the already formatted codewhere the
>should be dedented.See the issue for more examples.