Trace document registry operations - #47785
Merged
Merged
Conversation
...to help detect misconfigurations like microsoft#47687.
Andrew Casey (amcasey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Andrew Branch (andrewbranch)
February 7, 2022 21:17
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
| // It is fairly suspicious to have one path in two buckets - you'd expect dependencies to have similar configurations. | ||
| // If this occurs unexpectedly, the fix is likely to synchronize the project settings. | ||
| // Skip .d.ts files to reduce noise (should also cover most of node_modules). | ||
| const otherBucketKey = !fileExtensionIs(path, Extension.Dts) && |
Member
Author
There was a problem hiding this comment.
I could be persuaded that this is too chatty, but it has the advantage of indicating the proportion of overlap (e.g. a single-file overlap is likely uninteresting).
Andrew Branch (andrewbranch)
approved these changes
Feb 7, 2022
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Feb 7, 2022
Member
Author
|
Daniel Rosenwasser (@DanielRosenwasser) Okay for 4.6? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...to help detect misconfigurations like #47687.