Use node moduleResolution everywhere - #47687
Merged
Merged
Conversation
TestRunner was already using it, but upstream projects (e.g. Compiler) were not, causing TestRunner to re-parse and re-bind all upstream files in (at least) editor scenarios), slowing down initial project load. In local testing, this cut a find-all-refs call in checker.ts from 5s to 2.5s.
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Jake Bailey (jakebailey)
approved these changes
Feb 1, 2022
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
All for it, I can't believe this would harm anything.
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Feb 1, 2022
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Member
There was a problem hiding this comment.
I think the concern might've been with accidentally importing things. I don't think it's a big enough concern to block this change.
Member
|
Just tried a build with this change. After a cold start the language service is definitely quicker to respond to a find-all-references. Nice find! |
Member
Author
|
I'm planning to add some tracing so we can warn others if it's happening to them. |
Andrew Casey (amcasey)
added a commit
to amcasey/TypeScript
that referenced
this pull request
Feb 7, 2022
...to help detect misconfigurations like microsoft#47687.
Andrew Casey (amcasey)
added a commit
that referenced
this pull request
Feb 8, 2022
...to help detect misconfigurations like #47687.
|
Just want to say - thank you for adding this trace. It helped us debug why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestRunner was already using it, but upstream projects (e.g. Compiler) were not, causing TestRunner to re-parse and re-bind all upstream files in (at least) editor scenarios), slowing down initial project load.
In local testing, this cut a find-all-refs call in checker.ts from 5s to 2.5s.