Skip to content

Remove resolveUntypedCall from checkJsxSelfClosingElementDeferred #38515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented May 12, 2020

This doesn't cause any tests to fail; I'll see whether it causes user tests to fail.

This call is responsible for a 5% slowdown or so in ant-design, which is a generic react library with big types. So it's not too surprising that any additional checking is quite slow.

Fixes, or at least addresses, #38477

From discussion with @weswigham:

  1. This check was not technically needed in Fix get candidate for overload failure checking #36744 to replace the previous checks.
  2. But is definitely something we should be doing.

Additionally, I'd say:

  1. It's scary that we don't have any tests anywhere that notice this check disappearing.

This doesn't cause any tests to fail; I'll see whether it causes user
tests to fail.

This call is responsible for a 5% slowdown or so.
@sandersn
Copy link
Member Author

@typescript-bot user test this
@typescript-bot run tests

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 12, 2020

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 4a6f552. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn sandersn added the Experiment A fork with an experimental idea which might not make it into master label May 20, 2020
@weswigham
Copy link
Member

@sandersn #40293 supersedes this, includes a test which would have failed with just the removal of the call, and patches the branch of signature resolution that would have failed to error to provide an error so the call is no longer needed (and thus is removed).

@sandersn sandersn closed this Sep 8, 2020
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 8, 2020
@jakebailey jakebailey deleted the remove-resolveUntypedCall-from-checkJsxSelfClosingElementDeferred branch November 7, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team Experiment A fork with an experimental idea which might not make it into master For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants