Fix get candidate for overload failure checking #36744
Conversation
This re-adds the missed errors and marks as used missed nodes from the user and RWC baselines.
It was redundant with the old tests
|
@weswigham can you take a look? I'll assign you officially once the reviewers list loads. |
| function getCandidateForOverloadFailure( | ||
| node: CallLikeExpression, | ||
| candidates: Signature[], | ||
| args: readonly Expression[], | ||
| hasCandidatesOutArray: boolean, | ||
| ): Signature { | ||
| Debug.assert(candidates.length > 0); // Else should not have called this. | ||
| resolveUntypedCall(node); |
There was a problem hiding this comment.
@sandersn do you want to consider deferring this to the end of somehow (since it just needs to happen once for errors to be reported and usage to be painted, rather than on every attempted resolution)? Like how we have checkNodeDeferred? This does fix parameter types, and looking at the baselines, the parameter types we get from deferring this may be nicer that what's here.
Like this change is what I'm proposing - it looks like it minimizes the baseline diff a lot.
There was a problem hiding this comment.
Seems reasonable. I'll give it a try.
…rameter types fixed by overload signatures
|
OK, I just took your commit.
|
|
|
|
Nope, it's actually called by things like |
Fixes user and rwc test regressions, which I didn't file a bug for.