-
Notifications
You must be signed in to change notification settings - Fork 12.9k
🤖 User test baselines have changed for refs/heads/master #36617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sandersn
merged 1 commit into
microsoft:master
from
typescript-bot:user-update-Microsoft-20200103-refs/heads/master
Feb 5, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,9 @@ | ||
| Exit Code: 1 | ||
| Standard output: | ||
|
|
||
| > @reactivex/rxjs@X.X.X-alpha.0 build_all /rxjs | ||
| > npm-run-all clean_dist copy_sources build_cjs build_esm5 build_esm2015 build_esm5_for_rollup build_umd build_types generate_packages | ||
| > @reactivex/rxjs@X.X.X-alpha.0 clean_dist /rxjs | ||
| > shx rm -rf ./dist | ||
| > @reactivex/rxjs@X.X.X-alpha.0 copy_sources /rxjs | ||
| > mkdirp dist && shx cp -r ./src/ ./dist/src | ||
| > @reactivex/rxjs@X.X.X-alpha.0 build_cjs /rxjs | ||
| > npm-run-all clean_dist_cjs compile_dist_cjs | ||
| > @reactivex/rxjs@X.X.X-alpha.0 clean_dist_cjs /rxjs | ||
| > shx rm -rf ./dist/cjs | ||
| > @reactivex/rxjs@X.X.X-alpha.0 compile_dist_cjs /rxjs | ||
| > tsc -p ./tsconfig/tsconfig.cjs.json | ||
| node_modules/@types/node/index.d.ts(74,11): error TS2300: Duplicate identifier 'IteratorResult'. | ||
| src/internal/operators/windowTime.ts(115,5): error TS2322: Type 'string | number' is not assignable to type 'number'. | ||
| Type 'string' is not assignable to type 'number'. | ||
| src/internal/operators/windowTime.ts(121,5): error TS2322: Type 'string | number' is not assignable to type 'number'. | ||
| Type 'string' is not assignable to type 'number'. | ||
| ../typescript/package/lib/lib.es2015.iterable.d.ts(41,6): error TS2300: Duplicate identifier 'IteratorResult'. | ||
|
|
||
|
|
||
|
|
||
| Standard error: | ||
| npm ERR! code ELIFECYCLE | ||
| npm ERR! errno 2 | ||
| npm ERR! @reactivex/rxjs@X.X.X-alpha.0 compile_dist_cjs: `tsc -p ./tsconfig/tsconfig.cjs.json` | ||
| npm ERR! Exit status 2 | ||
| npm ERR! | ||
| npm ERR! Failed at the @reactivex/rxjs@X.X.X-alpha.0 compile_dist_cjs script. | ||
| npm ERR! This is probably not a problem with npm. There is likely additional logging output above. | ||
| npm ERR! A complete log of this run can be found in: | ||
| npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log | ||
| ERROR: "compile_dist_cjs" exited with 2. | ||
| npm ERR! code ELIFECYCLE | ||
| npm ERR! errno 1 | ||
| npm ERR! @reactivex/rxjs@X.X.X-alpha.0 build_cjs: `npm-run-all clean_dist_cjs compile_dist_cjs` | ||
| npm ERR! Exit status 1 | ||
| npm ERR! | ||
| npm ERR! Failed at the @reactivex/rxjs@X.X.X-alpha.0 build_cjs script. | ||
| npm ERR! This is probably not a problem with npm. There is likely additional logging output above. | ||
| npm ERR! A complete log of this run can be found in: | ||
| npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log | ||
| ERROR: "build_cjs" exited with 1. | ||
| npm ERR! code ELIFECYCLE | ||
| npm ERR! errno 1 | ||
| npm ERR! @reactivex/rxjs@X.X.X-alpha.0 build_all: `npm-run-all clean_dist copy_sources build_cjs build_esm5 build_esm2015 build_esm5_for_rollup build_umd build_types generate_packages` | ||
| npm ERR! Exit status 1 | ||
| npm ERR! | ||
| npm ERR! Failed at the @reactivex/rxjs@X.X.X-alpha.0 build_all script. | ||
| npm ERR! This is probably not a problem with npm. There is likely additional logging output above. | ||
| npm ERR! missing script: build_all | ||
| npm ERR! A complete log of this run can be found in: | ||
| npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a correct error; the target signature has no parameters so
choicedoesn't have anywhere to get a type from.The mystery is why we didn't report this earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
choiceis marked optional on the argument ((choice?) => ...), so I guess we're reporting this error on optionals now. This seems correct and not too bad a breaking change. However, @DanielRosenwasser should know about it in case we need to report it in the notes.