🤖 User test baselines have changed for refs/heads/master #36617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sandersn
reviewed
Feb 5, 2020
| [XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/protocol.d.ts(13,3): Duplicate identifier 'PrepareCallHierarchy'. | ||
| [XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/protocol.d.ts(14,3): Duplicate identifier 'ProvideCallHierarchyIncomingCalls'. | ||
| [XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/protocol.d.ts(15,3): Duplicate identifier 'ProvideCallHierarchyOutgoingCalls'. | ||
| [XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/remote/browser/remote.ts(637,8): Parameter 'choice' implicitly has an 'any' type. |
There was a problem hiding this comment.
this is a correct error; the target signature has no parameters so choice doesn't have anywhere to get a type from.
The mystery is why we didn't report this earlier.
There was a problem hiding this comment.
choice is marked optional on the argument ((choice?) => ...), so I guess we're reporting this error on optionals now. This seems correct and not too bad a breaking change. However, @DanielRosenwasser should know about it in case we need to report it in the notes.
typescript-bot
force-pushed
the
user-update-Microsoft-20200103-refs/heads/master
branch
5 times, most recently
from
92ee08d to
e5f1e77
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20200103-refs/heads/master
branch
from
e5f1e77 to
e4876ef
Compare
sandersn
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript