Skip to content

🤖 User test baselines have changed #32059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions tests/baselines/reference/docker/azure-sdk.log
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,8 @@ Starting "rush rebuild"

Executing a maximum of 1 simultaneous processes...

[@azure/abort-controller] started
XX of XX: [@azure/abort-controller] completed successfully in ? seconds
[@azure/cosmos] started
XX of XX: [@azure/cosmos] completed successfully in ? seconds
[@azure/event-hubs] started
XX of XX: [@azure/event-hubs] completed successfully in ? seconds
[@azure/service-bus] started
Warning: You have changed the public API signature for this project. Updating review/service-bus.api.md
[@azure/storage-blob] started
Expand All @@ -27,6 +23,8 @@ XX of XX: [@azure/storage-file] completed successfully in ? seconds
XX of XX: [@azure/storage-queue] completed successfully in ? seconds
[@azure/template] started
XX of XX: [@azure/template] completed successfully in ? seconds
[@azure/abort-controller] started
XX of XX: [@azure/abort-controller] completed successfully in ? seconds
[@azure/core-http] started
XX of XX: [@azure/core-http] completed successfully in ? seconds
[@azure/core-paging] started
Expand All @@ -37,21 +35,20 @@ XX of XX: [@azure/event-processor-host] completed successfully in ? seconds
XX of XX: [testhub] completed successfully in ? seconds
[@azure/identity] started
XX of XX: [@azure/identity] completed successfully in ? seconds
[@azure/core-amqp] started
[@azure/keyvault-certificates] started
XX of XX: [@azure/keyvault-certificates] completed successfully in ? seconds
[@azure/keyvault-keys] started
XX of XX: [@azure/keyvault-keys] completed successfully in ? seconds
[@azure/keyvault-secrets] started
XX of XX: [@azure/keyvault-secrets] completed successfully in ? seconds
[@azure/core-amqp] started

SUCCESS (16)
SUCCESS (15)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure-sdk seems to change their build day-to-day, which seems surprising. But if it's true, then I guess the diff is expected.

================================
@azure/abort-controller (? seconds)
@azure/core-http (? seconds)
@azure/core-paging (? seconds)
@azure/cosmos (? seconds)
@azure/event-hubs (? seconds)
@azure/event-processor-host (? seconds)
@azure/identity (? seconds)
@azure/keyvault-certificates (? seconds)
Expand All @@ -71,14 +68,19 @@ SUCCESS WITH WARNINGS (1)
Warning: You have changed the public API signature for this project. Updating review/service-bus.api.md
================================

BLOCKED (1)
================================
@azure/event-hubs
================================

FAILURE (1)
================================
@azure/core-amqp (? seconds)
>>> @azure/core-amqp
tsc -p . && rollup -c 2>&1
src/errors.ts(579,20): error TS7053: Element implicitly has an 'any' type because expression of type 'any' can't be used to index type 'typeof ConditionErrorNameMapper'.
src/errors.ts(600,34): error TS7053: Element implicitly has an 'any' type because expression of type 'any' can't be used to index type 'typeof SystemErrorConditionMapper'.
src/errors.ts(601,20): error TS7053: Element implicitly has an 'any' type because expression of type 'any' can't be used to index type 'typeof ConditionErrorNameMapper'.
src/errors.ts(586,20): error TS7053: Element implicitly has an 'any' type because expression of type 'any' can't be used to index type 'typeof ConditionErrorNameMapper'.
src/errors.ts(607,34): error TS7053: Element implicitly has an 'any' type because expression of type 'any' can't be used to index type 'typeof SystemErrorConditionMapper'.
src/errors.ts(608,20): error TS7053: Element implicitly has an 'any' type because expression of type 'any' can't be used to index type 'typeof ConditionErrorNameMapper'.
================================


Expand All @@ -92,4 +94,5 @@ Your version of Node.js (12.4.0) has not been tested with this release of Rush.
XX of XX: [@azure/service-bus] completed with warnings in ? seconds

XX of XX: [@azure/core-amqp] failed to build!
XX of XX: [@azure/event-hubs] blocked by [@azure/core-amqp]!
[@azure/core-amqp] Returned error code: 2
12 changes: 6 additions & 6 deletions tests/baselines/reference/user/adonis-framework.log
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ node_modules/adonis-framework/src/Encryption/index.js(85,23): error TS8024: JSDo
node_modules/adonis-framework/src/Encryption/index.js(87,15): error TS2304: Cannot find name 'Mixed'.
node_modules/adonis-framework/src/Encryption/index.js(101,62): error TS2345: Argument of type 'string' is not assignable to parameter of type 'Utf8AsciiBinaryEncoding'.
node_modules/adonis-framework/src/Encryption/index.js(114,15): error TS2304: Cannot find name 'Mixed'.
node_modules/adonis-framework/src/Encryption/index.js(119,18): error TS2554: Expected 2 arguments, but got 1.
node_modules/adonis-framework/src/Encryption/index.js(119,23): error TS2554: Expected 2 arguments, but got 1.
node_modules/adonis-framework/src/Encryption/index.js(183,15): error TS2304: Cannot find name 'Mixed'.
node_modules/adonis-framework/src/Encryption/index.js(197,15): error TS2304: Cannot find name 'Mixed'.
node_modules/adonis-framework/src/Encryption/index.js(209,14): error TS8024: JSDoc '@param' tag has name 'object', but there is no parameter with that name.
Expand Down Expand Up @@ -69,7 +69,7 @@ node_modules/adonis-framework/src/File/index.js(273,5): error TS2322: Type 'bool
Type '""' is not assignable to type 'boolean'.
node_modules/adonis-framework/src/Helpers/index.js(105,3): error TS2322: Type 'null' is not assignable to type 'string'.
node_modules/adonis-framework/src/Helpers/index.js(106,3): error TS2322: Type 'null' is not assignable to type 'string'.
node_modules/adonis-framework/src/Helpers/index.js(164,10): error TS2554: Expected 3 arguments, but got 2.
node_modules/adonis-framework/src/Helpers/index.js(164,18): error TS2554: Expected 3 arguments, but got 2.
node_modules/adonis-framework/src/Helpers/index.js(178,45): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
node_modules/adonis-framework/src/Helpers/index.js(224,45): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Expand Down Expand Up @@ -100,8 +100,8 @@ node_modules/adonis-framework/src/Request/index.js(482,15): error TS2304: Cannot
node_modules/adonis-framework/src/Request/index.js(499,17): error TS2551: Property '_params' does not exist on type 'Request'. Did you mean 'param'?
node_modules/adonis-framework/src/Request/index.js(523,15): error TS2304: Cannot find name 'Objecr'.
node_modules/adonis-framework/src/Request/index.js(572,23): error TS8029: JSDoc '@param' tag has name 'pattern', but there is no parameter with that name. It would match 'arguments' if it had an array type.
node_modules/adonis-framework/src/Request/index.js(600,12): error TS2554: Expected 2 arguments, but got 1.
node_modules/adonis-framework/src/Request/index.js(600,35): error TS2554: Expected 2 arguments, but got 1.
node_modules/adonis-framework/src/Request/index.js(600,17): error TS2554: Expected 2 arguments, but got 1.
node_modules/adonis-framework/src/Request/index.js(600,40): error TS2554: Expected 2 arguments, but got 1.
node_modules/adonis-framework/src/Request/index.js(663,23): error TS8024: JSDoc '@param' tag has name 'encodings', but there is no parameter with that name.
node_modules/adonis-framework/src/Response/index.js(44,7): error TS1056: Accessors are only available when targeting ECMAScript 5 and higher.
node_modules/adonis-framework/src/Response/index.js(56,7): error TS1056: Accessors are only available when targeting ECMAScript 5 and higher.
Expand Down Expand Up @@ -157,7 +157,7 @@ node_modules/adonis-framework/src/Route/resource.js(296,15): error TS2304: Canno
node_modules/adonis-framework/src/Route/resource.js(314,62): error TS2345: Argument of type 'IArguments' is not assignable to parameter of type 'any[]'.
node_modules/adonis-framework/src/Server/helpers.js(17,29): error TS8024: JSDoc '@param' tag has name 'appNamespace', but there is no parameter with that name.
node_modules/adonis-framework/src/Server/index.js(17,21): error TS2307: Cannot find module 'adonis-fold'.
node_modules/adonis-framework/src/Server/index.js(54,21): error TS2554: Expected 4 arguments, but got 3.
node_modules/adonis-framework/src/Server/index.js(54,29): error TS2554: Expected 4 arguments, but got 3.
node_modules/adonis-framework/src/Server/index.js(137,25): error TS8024: JSDoc '@param' tag has name 'handlers', but there is no parameter with that name.
node_modules/adonis-framework/src/Server/index.js(252,15): error TS2304: Cannot find name 'instance'.
node_modules/adonis-framework/src/Server/index.js(252,24): error TS1005: '}' expected.
Expand Down Expand Up @@ -211,7 +211,7 @@ node_modules/adonis-framework/src/View/Form/index.js(147,63): error TS2345: Argu
node_modules/adonis-framework/src/View/Form/index.js(151,58): error TS2345: Argument of type 'string | any[]' is not assignable to parameter of type 'any[]'.
Type 'string' is not assignable to type 'any[]'.
node_modules/adonis-framework/src/View/Form/index.js(415,37): error TS2345: Argument of type 'null' is not assignable to parameter of type 'string'.
node_modules/adonis-framework/src/View/Form/index.js(578,20): error TS2554: Expected 2 arguments, but got 1.
node_modules/adonis-framework/src/View/Form/index.js(578,25): error TS2554: Expected 2 arguments, but got 1.
node_modules/adonis-framework/src/View/Form/index.js(601,51): error TS2345: Argument of type 'number | any[]' is not assignable to parameter of type 'string | any[]'.
Type 'number' is not assignable to type 'string | any[]'.
node_modules/adonis-framework/src/View/index.js(50,23): error TS8024: JSDoc '@param' tag has name 'template_path', but there is no parameter with that name.
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/user/axios-src.log
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ lib/adapters/xhr.js(81,51): error TS2345: Argument of type 'null' is not assigna
lib/adapters/xhr.js(84,7): error TS2322: Type 'null' is not assignable to type 'XMLHttpRequest'.
lib/adapters/xhr.js(93,7): error TS2322: Type 'null' is not assignable to type 'XMLHttpRequest'.
lib/adapters/xhr.js(163,9): error TS2322: Type 'null' is not assignable to type 'XMLHttpRequest'.
lib/axios.js(23,3): error TS2554: Expected 3 arguments, but got 2.
lib/axios.js(23,9): error TS2554: Expected 3 arguments, but got 2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error span is on the name of the property access expression instead of the expression. That's an improvement.

lib/axios.js(25,3): error TS2739: Type '(...args: any[]) => any' is missing the following properties from type 'Axios': defaults, interceptors, request, getUri
lib/axios.js(32,7): error TS2339: Property 'Axios' does not exist on type 'Axios'.
lib/axios.js(35,7): error TS2339: Property 'create' does not exist on type 'Axios'.
Expand Down
Loading