🤖 User test baselines have changed #32059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
force-pushed
the
user-update-Microsoft-20190501
branch
from
fef5865 to
bf07a5f
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20190501
branch
from
bf07a5f to
1c2bdc8
Compare
sandersn
approved these changes
Jun 24, 2019
| @@ -19,7 +19,7 @@ lib/adapters/xhr.js(81,51): error TS2345: Argument of type 'null' is not assigna | |||
| lib/adapters/xhr.js(84,7): error TS2322: Type 'null' is not assignable to type 'XMLHttpRequest'. | |||
| lib/adapters/xhr.js(93,7): error TS2322: Type 'null' is not assignable to type 'XMLHttpRequest'. | |||
| lib/adapters/xhr.js(163,9): error TS2322: Type 'null' is not assignable to type 'XMLHttpRequest'. | |||
| lib/axios.js(23,3): error TS2554: Expected 3 arguments, but got 2. | |||
| lib/axios.js(23,9): error TS2554: Expected 3 arguments, but got 2. | |||
There was a problem hiding this comment.
error span is on the name of the property access expression instead of the expression. That's an improvement.
|
|
||
| SUCCESS (16) | ||
| SUCCESS (15) |
There was a problem hiding this comment.
azure-sdk seems to change their build day-to-day, which seems surprising. But if it's true, then I guess the diff is expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh