Skip to content

Conversation

@weswigham
Copy link
Member

The implments quick fixes were not providing the host required to generate good paths for import types into the type node helpers they used, so they were always generating absolute paths (or amd module names).

Fixes #29406

Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good except the question about signature help (with dynamicImport.C as parameter invocation?)

@weswigham
Copy link
Member Author

@sheetalkamat the symbolDisplay files always specifies UseAliasDefinedOutsideCurrentScope, so it should never need to use import types (it'll use aliases not in scope), so signature help shouldn't need any adjustment AFAIK.

@weswigham weswigham merged commit 3d2bf6a into microsoft:master Jan 14, 2019
@weswigham weswigham deleted the fix-implement-interface-quickfix-import-types branch January 14, 2019 21:56
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Absolute import(...) path used in type for the implement interface quick fix

2 participants