Skip to content

Absolute import(...) path used in type for the implement interface quick fix #29406

@mjbvz

Description

@mjbvz

From microsoft/vscode#66191

TypeScript Version: 3.3.0-dev.20190112

Search Terms:

  • Implement interface
  • quick fix
  • code action

Repo
(see comment for simpler repo)

  1. In the VS Code codebase
  2. Open src/vs/workbench/browser/parts/editor/editor.ts
  3. At the top of the file, add the code:
class Foo implements ISerializableView {

}
  1. Trigger the implement interface quick fix on Foo

Bug:
priority uses an import type with an absolute path:

class Foo implements ISerializableView {
	toJSON(): object {
		throw new Error('Method not implemented.');
	}	element: HTMLElement;
	minimumWidth: number;
	maximumWidth: number;
	minimumHeight: number;
	maximumHeight: number;
	onDidChange: Event<{ width: number; height: number; }>;
	priority?: import("/Users/matb/projects/vscode/src/vs/base/browser/ui/splitview/splitview").LayoutPriority;
	snapSize?: number;
	layout(width: number, height: number): void {
		throw new Error('Method not implemented.');
	}


}

This seems related to ISerializableView extending another interface which uses types defined in other files

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptDomain: LS: Quick FixesEditor-provided fixes, often called code actions.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions