-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Closed
Closed
Copy link
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: LS: Quick FixesEditor-provided fixes, often called code actions.Editor-provided fixes, often called code actions.
Description
TypeScript Version: 3.3.0-dev.20190112
Search Terms:
- Implement interface
- quick fix
- code action
Repo
(see comment for simpler repo)
- In the VS Code codebase
- Open
src/vs/workbench/browser/parts/editor/editor.ts - At the top of the file, add the code:
class Foo implements ISerializableView {
}- Trigger the
implement interfacequick fix onFoo
Bug:
priority uses an import type with an absolute path:
class Foo implements ISerializableView {
toJSON(): object {
throw new Error('Method not implemented.');
} element: HTMLElement;
minimumWidth: number;
maximumWidth: number;
minimumHeight: number;
maximumHeight: number;
onDidChange: Event<{ width: number; height: number; }>;
priority?: import("/Users/matb/projects/vscode/src/vs/base/browser/ui/splitview/splitview").LayoutPriority;
snapSize?: number;
layout(width: number, height: number): void {
throw new Error('Method not implemented.');
}
}This seems related to ISerializableView extending another interface which uses types defined in other files
Metadata
Metadata
Assignees
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: LS: Quick FixesEditor-provided fixes, often called code actions.Editor-provided fixes, often called code actions.