Allow referencing 'this' in parameters of functions in the constructor #29298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
approved these changes
Jan 7, 2019
|
Interesting; you can probably only get away with this in TS's ES5 emit because you don't use (It is valid ES2015, of course, just hard to transpile to ES5-) |
|
@kovensky can you give an example of what you think might fail when downlevelled to ES5? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29286
This also affects referencing
superin parameters or unrelated functions.A future PR could update this check to treat immediately invoked arrow functions as inlined (like #29160 does for 'parameter cannot reference identifiers declared after it')