Skip to content

fix parameter initializer referencing identifier declared after it #29160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Dec 26, 2018

  • treat IIFEs as inlined
  • check computed property names
  • check ShorthandPropertyAssignment

Fixes: #29139

* treat IIFEs as inlined
* check computed property names
* check ShorthandPropertyAssignment

Fixes: microsoft#29139
@Kingwl
Copy link
Contributor

Kingwl commented Dec 27, 2018

toooooooooo difficult about that🤦🏻‍♂️

@RyanCavanaugh
Copy link
Member

@weswigham some fun semantics validation for you

@weswigham
Copy link
Member

I started reviewing this, then realized that I hated how checkParameterInitializer worked entirely. I have opened #30349, which refactors the same checks into resolveName, which is, IMO, where they should have been all along.

@weswigham weswigham closed this Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing error 'initializer of parameter 'foo' cannot reference identifier 'bas' declared after it' within IIFE
4 participants