-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Project references transitional: Remove reference comments #23354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RyanCavanaugh
merged 15 commits into
microsoft:master
from
RyanCavanaugh:referencesDogfood_1
Apr 12, 2018
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8294259
Remove all reference comments from compiler/
RyanCavanaugh 5b32549
Explicitly list compiler source files in their current emitted order
RyanCavanaugh 3ca1d2d
Remove all reference comments from server/
RyanCavanaugh 21d1669
Explicitly list server source files in their current emitted order
RyanCavanaugh 034b8ee
Remove explicit harness file list from Jakefile
RyanCavanaugh bb8fd41
Fix harness file listing
RyanCavanaugh 501d7be
Add explicit file lists to server tsconfig files
RyanCavanaugh 9a5a5b1
Remove all reference comments from services
RyanCavanaugh e1a5036
.d.ts changed order
RyanCavanaugh df95de3
Merge branch 'master' into referencesDogfood_1
RyanCavanaugh 0e07d77
You have to do this everywhere now!
RyanCavanaugh f24d57f
Update diagnostic tasks in jakefile
RyanCavanaugh ff60520
Merge branch 'master' into referencesDogfood_1
RyanCavanaugh bbcf00c
Remove ref comments from processDiagnosticMessages
RyanCavanaugh 8e36afa
Remove reference emit from diagnostics
RyanCavanaugh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
{ | ||
"compilerOptions": { | ||
"removeComments": false, | ||
"outFile": "processDiagnosticMessages.js", | ||
"target": "es5", | ||
"declaration": false, | ||
"lib": [ | ||
"es6", | ||
"scripthost" | ||
] | ||
}, | ||
"files": [ | ||
"../src/compiler/types.ts", | ||
"../src/compiler/performance.ts", | ||
"../src/compiler/core.ts", | ||
"../src/compiler/sys.ts", | ||
"../src/compiler/diagnosticInformationMap.generated.ts", | ||
"../src/compiler/scanner.ts", | ||
"../src/compiler/utilities.ts", | ||
"../src/compiler/parser.ts", | ||
"../src/compiler/binder.ts", | ||
"../src/compiler/symbolWalker.ts", | ||
"../src/compiler/moduleNameResolver.ts", | ||
"../src/compiler/checker.ts", | ||
"../src/compiler/factory.ts", | ||
"../src/compiler/visitor.ts", | ||
"../src/compiler/transformers/utilities.ts", | ||
"../src/compiler/transformers/destructuring.ts", | ||
"../src/compiler/transformers/ts.ts", | ||
"../src/compiler/transformers/es2017.ts", | ||
"../src/compiler/transformers/esnext.ts", | ||
"../src/compiler/transformers/jsx.ts", | ||
"../src/compiler/transformers/es2016.ts", | ||
"../src/compiler/transformers/es2015.ts", | ||
"../src/compiler/transformers/es5.ts", | ||
"../src/compiler/transformers/generators.ts", | ||
"../src/compiler/transformers/module/module.ts", | ||
"../src/compiler/transformers/module/system.ts", | ||
"../src/compiler/transformers/module/es2015.ts", | ||
"../src/compiler/transformers/declarations/diagnostics.ts", | ||
"../src/compiler/transformers/declarations.ts", | ||
"../src/compiler/transformer.ts", | ||
"../src/compiler/sourcemap.ts", | ||
"../src/compiler/comments.ts", | ||
"../src/compiler/emitter.ts", | ||
"../src/compiler/watchUtilities.ts", | ||
"../src/compiler/program.ts", | ||
"../src/compiler/builderState.ts", | ||
"../src/compiler/builder.ts", | ||
"../src/compiler/resolutionCache.ts", | ||
"../src/compiler/watch.ts", | ||
"../src/compiler/commandLineParser.ts", | ||
|
||
"processDiagnosticMessages.ts" | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
/// <reference path="builderState.ts" /> | ||
|
||
/*@internal*/ | ||
namespace ts { | ||
/** | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
/// <reference path="program.ts" /> | ||
namespace ts { | ||
export interface EmitOutput { | ||
outputFiles: OutputFile[]; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
/// <reference path="sourcemap.ts" /> | ||
|
||
/* @internal */ | ||
namespace ts { | ||
export interface CommentWriter { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
/// <reference path="checker.ts"/> | ||
|
||
/* @internal */ | ||
namespace ts { | ||
export interface SourceMapWriter { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
/// <reference path="../factory.ts" /> | ||
/// <reference path="../visitor.ts" /> | ||
|
||
/*@internal*/ | ||
namespace ts { | ||
/** | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to change processDiagnosticMessages.ts to not include reference path in generated diagnostics file https://github.com/Microsoft/TypeScript/blob/master/scripts/processDiagnosticMessages.ts#L60