Project references transitional: Remove reference comments #23354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "../src/compiler/watch.ts", | ||
| "../src/compiler/commandLineParser.ts", | ||
|
|
||
| "processDiagnosticMessages.ts" |
There was a problem hiding this comment.
Also need to change processDiagnosticMessages.ts to not include reference path in generated diagnostics file https://github.com/Microsoft/TypeScript/blob/master/scripts/processDiagnosticMessages.ts#L60
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking from #23324
This removes all
referencecomments from our main source files and replaces them with explicit file lists in tsconfigs. This makes the output ordering of our various outputs actually similar, instead of random. Total output size inbuilt\localis effectively unchanged so I'm reasonably sure I didn't break anything.The next step is to merge the core references support and replace the long file lists in the tsconfig files with reference directives.