Skip to content

Update user test baselines #23181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
327 changes: 92 additions & 235 deletions tests/baselines/reference/user/acorn.log

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions tests/baselines/reference/user/antd.log
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
Exit Code: 1
Standard output:
node_modules/antd/lib/badge/ScrollNumber.d.ts(28,81): error TS2344: Type '{ className: string; style: { transition: string | boolean; msTransform: string; WebkitTransform:...' does not satisfy the constraint 'HTMLAttributes<HTMLElement>'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that caused by a change in the source, or a change on our side?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing without investigating: added constraint in react.d.ts. I'll check it out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, here it is, from 3 days ago: DefinitelyTyped/DefinitelyTyped#24688

Types of property 'style' are incompatible.
Type '{ transition: string | boolean; msTransform: string; WebkitTransform: string; transform: string; }' is not assignable to type 'CSSProperties | undefined'.
Type '{ transition: string | boolean; msTransform: string; WebkitTransform: string; transform: string; }' is not assignable to type 'CSSProperties'.
Types of property 'transition' are incompatible.
Type 'string | boolean' is not assignable to type 'string | undefined'.
Type 'true' is not assignable to type 'string | undefined'.
node_modules/antd/lib/badge/ScrollNumber.d.ts(38,77): error TS2344: Type '{ className: string; style: { transition: string | boolean; msTransform: string; WebkitTransform:...' does not satisfy the constraint 'HTMLAttributes<HTMLElement>'.
Types of property 'style' are incompatible.
Type '{ transition: string | boolean; msTransform: string; WebkitTransform: string; transform: string; }' is not assignable to type 'CSSProperties | undefined'.
Type '{ transition: string | boolean; msTransform: string; WebkitTransform: string; transform: string; }' is not assignable to type 'CSSProperties'.
Types of property 'transition' are incompatible.
Type 'string | boolean' is not assignable to type 'string | undefined'.
Type 'true' is not assignable to type 'string | undefined'.



Standard error:
266 changes: 125 additions & 141 deletions tests/baselines/reference/user/async.log

Large diffs are not rendered by default.

15 changes: 2 additions & 13 deletions tests/baselines/reference/user/bcryptjs.log
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Exit Code: 1
Standard output:
../../../../node_modules/@types/node/index.d.ts(138,13): error TS2300: Duplicate identifier 'require'.
../../../../node_modules/@types/node/index.d.ts(150,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'module' must be of type '{ exports: any; }', but here has type 'NodeModule'.
../../../../node_modules/@types/node/index.d.ts(174,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'Buffer' must be of type '(s: string) => void', but here has type '{ new (str: string, encoding?: string | undefined): Buffer; new (size: number): Buffer; new (arra...'.
../../../../node_modules/@types/node/index.d.ts(150,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'module' must be of type 'Module', but here has type 'NodeModule'.
../../../../node_modules/@types/node/index.d.ts(174,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'Buffer' must be of type 'typeof Buffer', but here has type '{ new (str: string, encoding?: string | undefined): Buffer; new (size: number): Buffer; new (arra...'.
node_modules/bcryptjs/dist/bcrypt.js(37,16): error TS2345: Argument of type 'never[]' is not assignable to parameter of type 'string'.
node_modules/bcryptjs/dist/bcrypt.js(134,18): error TS2366: Function lacks ending return statement and return type does not include 'undefined'.
node_modules/bcryptjs/dist/bcrypt.js(165,24): error TS2693: 'Promise' only refers to a type, but is being used as a value here.
Expand All @@ -12,11 +12,6 @@ node_modules/bcryptjs/dist/bcrypt.js(200,18): error TS2366: Function lacks endin
node_modules/bcryptjs/dist/bcrypt.js(222,24): error TS2693: 'Promise' only refers to a type, but is being used as a value here.
node_modules/bcryptjs/dist/bcrypt.js(278,18): error TS2366: Function lacks ending return statement and return type does not include 'undefined'.
node_modules/bcryptjs/dist/bcrypt.js(306,24): error TS2693: 'Promise' only refers to a type, but is being used as a value here.
node_modules/bcryptjs/dist/bcrypt.js(348,25): error TS8028: JSDoc '...' may only appear in the last parameter of a signature.
node_modules/bcryptjs/dist/bcrypt.js(401,9): error TS2322: Type '(...codes: number[]) => string' is not assignable to type '(arg0: number | undefined) => string'.
Types of parameters 'codes' and 'arg0' are incompatible.
Type 'number | undefined' is not assignable to type 'number'.
Type 'undefined' is not assignable to type 'number'.
node_modules/bcryptjs/dist/bcrypt.js(563,42): error TS2531: Object is possibly 'null'.
node_modules/bcryptjs/dist/bcrypt.js(566,44): error TS2531: Object is possibly 'null'.
node_modules/bcryptjs/dist/bcrypt.js(566,59): error TS2533: Object is possibly 'null' or 'undefined'.
Expand Down Expand Up @@ -45,7 +40,6 @@ node_modules/bcryptjs/externs/minimal-env.js(65,8): error TS2339: Property 'rand
node_modules/bcryptjs/externs/minimal-env.js(70,8): error TS2540: Cannot assign to 'crypto' because it is a constant or a read-only property.
node_modules/bcryptjs/externs/minimal-env.js(75,1): error TS2322: Type '(array: Int8Array | Uint8Array | Int16Array | Uint16Array | Int32Array | Uint32Array) => void' is not assignable to type '(array: DataView | Int8Array | Uint8Array | Uint8ClampedArray | Int16Array | Uint16Array | Int32A...'.
Type 'void' is not assignable to type 'DataView | Int8Array | Uint8Array | Uint8ClampedArray | Int16Array | Uint16Array | Int32Array | U...'.
node_modules/bcryptjs/externs/minimal-env.js(79,21): error TS8028: JSDoc '...' may only appear in the last parameter of a signature.
node_modules/bcryptjs/externs/minimal-env.js(90,14): error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value.
node_modules/bcryptjs/externs/minimal-env.js(92,8): error TS2339: Property 'fromCodePoint' does not exist on type 'StringConstructor'.
node_modules/bcryptjs/externs/minimal-env.js(96,14): error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value.
Expand Down Expand Up @@ -90,12 +84,7 @@ node_modules/bcryptjs/src/bcrypt/prng/accum.js(53,22): error TS2339: Property 'a
node_modules/bcryptjs/src/bcrypt/prng/accum.js(65,74): error TS2339: Property 'detachEvent' does not exist on type 'Document'.
node_modules/bcryptjs/src/bcrypt/prng/accum.js(66,22): error TS2339: Property 'detachEvent' does not exist on type 'Document'.
node_modules/bcryptjs/src/bcrypt/prng/accum.js(67,22): error TS2339: Property 'detachEvent' does not exist on type 'Document'.
node_modules/bcryptjs/src/bcrypt/util.js(4,21): error TS8028: JSDoc '...' may only appear in the last parameter of a signature.
node_modules/bcryptjs/src/bcrypt/util.js(20,5): error TS2304: Cannot find name 'utfx'.
node_modules/bcryptjs/src/bcrypt/util/base64.js(29,5): error TS2322: Type '(...codes: number[]) => string' is not assignable to type '(arg0: number | undefined) => string'.
Types of parameters 'codes' and 'arg0' are incompatible.
Type 'number | undefined' is not assignable to type 'number'.
Type 'undefined' is not assignable to type 'number'.
node_modules/bcryptjs/src/wrap.js(38,16): error TS2345: Argument of type 'never[]' is not assignable to parameter of type 'string'.
node_modules/bcryptjs/tests/suite.js(4,27): error TS2339: Property 'join' does not exist on type 'void'.
node_modules/bcryptjs/tests/suite.js(15,26): error TS2339: Property 'encodeBase64' does not exist on type 'void'.
Expand Down
Loading