Skip to content

Update user test baselines #23181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2018
Merged

Update user test baselines #23181

merged 2 commits into from
Apr 6, 2018

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Apr 5, 2018 •
edited
Loading

There are a ton of changes in here. By far the biggest by count of lines is improved names for anonymous classes and functions.

  • No more conflicts when extending a normal method with a prototype assignment (and vice versa)
  • Better parsing of ... and = in jsdoc
  • Better printing of import types
  • More lenient parsing of jsdoc parameter names
  • Initializers of null/undefined and [] get the types any and any[]
  • Other binding fixes
  • And many more.

@sandersn sandersn requested a review from weswigham April 5, 2018 21:28
mhegazy
mhegazy reviewed Apr 6, 2018
View reviewed changes
tests/baselines/reference/user/clone.log
node_modules/clone/clone.js(180,16): error TS2403: Subsequent variable declarations must have the same type. Variable 'i' must be of type 'string', but here has type 'number'.
node_modules/clone/clone.js(180,23): error TS2365: Operator '<' cannot be applied to types 'string' and 'number'.
node_modules/clone/clone.js(180,52): error TS2356: An arithmetic operand must be of type 'any', 'number' or an enum type.
node_modules/clone/clone.js(165,16): error TS2551: Property 'getOwnPropertySymbols' does not exist on type 'ObjectConstructor'. Did you mean 'getOwnPropertyNames'?
Copy link
Contributor

@mhegazy mhegazy Apr 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the --lib we are using to compile these files? we should be using --lib esnext, and dom when appropriate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not specified, which I think means es5+dom. I'll make the change in a separate PR, though, to keep it separate from this update.

mhegazy
mhegazy approved these changes Apr 6, 2018
View reviewed changes
Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks better than before, a few comments

tests/baselines/reference/user/follow-redirects.log
node_modules/follow-redirects/index.js(208,10): error TS2339: Property '_isRedirect' does not exist on type '{ _options: any; _redirectCount: number | undefined; _requestBodyLength: number | undefined; _req...'.
node_modules/follow-redirects/index.js(213,33): error TS2339: Property '_currentUrl' does not exist on type '{ _options: any; _redirectCount: number | undefined; _requestBodyLength: number | undefined; _req...'.
node_modules/follow-redirects/index.js(214,10): error TS2339: Property 'emit' does not exist on type '{ _options: any; _redirectCount: number | undefined; _requestBodyLength: number | undefined; _req...'.
node_modules/follow-redirects/index.js(214,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(243,26): error TS2339: Property 'assign' does not exist on type 'ObjectConstructor'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like another instance of the library not being right.

tests/baselines/reference/user/webpack.log
node_modules/webpack/lib/Compiler.js(365,7): error TS2339: Property 'includes' does not exist on type 'string[]'.
node_modules/webpack/lib/Compiler.js(433,32): error TS2554: Expected 0-1 arguments, but got 2.
node_modules/webpack/lib/Compiler.js(445,33): error TS2304: Cannot find name 'Set'.
node_modules/webpack/lib/Compilation.js(240,26): error TS2304: Cannot find name 'Map'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib issue too

tests/baselines/reference/user/webpack.log
node_modules/webpack/lib/Module.js(143,6): error TS1056: Accessors are only available when targeting ECMAScript 5 and higher.
node_modules/webpack/lib/Module.js(151,16): error TS2339: Property 'from' does not exist on type 'ArrayConstructor'.
node_modules/webpack/lib/Module.js(155,23): error TS2339: Property 'size' does not exist on type 'SortableSet'.
node_modules/webpack/lib/Module.js(158,6): error TS1056: Accessors are only available when targeting ECMAScript 5 and higher.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not use --target es3 really..

tests/baselines/reference/user/TypeScript-Node-Starter.log Outdated
@@ -0,0 +1,7 @@
Exit Code: 1
Standard output:
node_modules/@types/passport-facebook/index.d.ts(50,31): error TS2689: Cannot extend an interface 'passport.Strategy'. Did you mean 'implements'?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a DefinitllyTyped issue.. can we track the source down?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed 3 days ago: DefinitelyTyped/DefinitelyTyped#24682

Sounds like my npm installs are stale, or I need to re-run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it went away after re-running.

tests/baselines/reference/user/antd.log
@@ -0,0 +1,20 @@
Exit Code: 1
Standard output:
node_modules/antd/lib/badge/ScrollNumber.d.ts(28,81): error TS2344: Type '{ className: string; style: { transition: string | boolean; msTransform: string; WebkitTransform:...' does not satisfy the constraint 'HTMLAttributes<HTMLElement>'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that caused by a change in the source, or a change on our side?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing without investigating: added constraint in react.d.ts. I'll check it out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, here it is, from 3 days ago: DefinitelyTyped/DefinitelyTyped#24688

@sandersn
Copy link
Member Author

sandersn commented Apr 6, 2018

I'll fix the lib problems in a separate PR since it will make it easier to figure out whether my changes are removing errors.

@sandersn sandersn merged commit c466a45 into master Apr 6, 2018
@sandersn sandersn deleted the update-user-tests-042018 branch April 6, 2018 20:23
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @mhegazy