Skip to content

Enable incremental parsing by default. #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2014
Merged

Enable incremental parsing by default. #1568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,7 +1548,7 @@ module ts {
return sourceFile;
}

export var disableIncrementalParsing = true;
export var disableIncrementalParsing = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super anticlimactic for this review, but could we rename this to enableIncrementalParsing?

I think it's only referenced in tests/cases/unittests/incrementalParser.ts and src/harness/fourslash.ts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there's a comment on line 1575:

// Once incremental parsing is ready, then just call into this function.

So just remove that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but I prefer this. You are now choosing to opt out of incremental parsing by saying 'yes/true' I would like to disable incremental parsing.

-- Cyrus

From: Daniel Rosenwassermailto:notifications@github.com
Sent: ý12/ý27/ý2014 8:29 AM
To: Microsoft/TypeScriptmailto:TypeScript@noreply.github.com
Cc: Cyrus Najmabadimailto:cyrusn@microsoft.com
Subject: Re: [TypeScript] Enable incremental parsing by default. (#1568)

In src/services/services.tshttps://github.com//pull/1568#discussion-diff-22292557:

@@ -1548,7 +1548,7 @@ module ts {
return sourceFile;
}

  • export var disableIncrementalParsing = true;
  • export var disableIncrementalParsing = false;

Super anticlimactic for this review, but could we rename this to enableIncrementalParsing?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1568/files#r22292557.


export function updateLanguageServiceSourceFile(sourceFile: SourceFile, scriptSnapshot: IScriptSnapshot, version: string, isOpen: boolean, textChangeRange: TextChangeRange): SourceFile {
if (textChangeRange && Debug.shouldAssert(AssertionLevel.Normal)) {
Expand Down