Enable incremental parsing by default. #1568
Conversation
| @@ -1548,7 +1548,7 @@ module ts { | |||
| return sourceFile; | |||
| } | |||
|
|
|||
| export var disableIncrementalParsing = true; | |||
| export var disableIncrementalParsing = false; | |||
There was a problem hiding this comment.
Super anticlimactic for this review, but could we rename this to enableIncrementalParsing?
I think it's only referenced in tests/cases/unittests/incrementalParser.ts and src/harness/fourslash.ts.
There was a problem hiding this comment.
Also, there's a comment on line 1575:
// Once incremental parsing is ready, then just call into this function.
So just remove that.
There was a problem hiding this comment.
I thought about that, but I prefer this. You are now choosing to opt out of incremental parsing by saying 'yes/true' I would like to disable incremental parsing.
-- Cyrus
From: Daniel Rosenwassermailto:notifications@github.com
Sent: ý12/ý27/ý2014 8:29 AM
To: Microsoft/TypeScriptmailto:TypeScript@noreply.github.com
Cc: Cyrus Najmabadimailto:cyrusn@microsoft.com
Subject: Re: [TypeScript] Enable incremental parsing by default. (#1568)
In src/services/services.tshttps://github.com//pull/1568#discussion-diff-22292557:
@@ -1548,7 +1548,7 @@ module ts {
return sourceFile;
}
- export var disableIncrementalParsing = true;
- export var disableIncrementalParsing = false;
Super anticlimactic for this review, but could we rename this to enableIncrementalParsing?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1568/files#r22292557.
|
|
Enable incremental parsing by default.
No description provided.