Skip to content

Add PathCompletions namespace #14067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add PathCompletions namespace #14067

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2017

…as this code is mostly independent of the rest of completions.

This is like the ImportTracker namespace in #14001. It's a component of a service that has little coupling to the rest of the service; it's 500+ lines of code with only 2 exports. Not sure if this should go in its own file too.

It's hard to see from the diff, but this just moves functions out of ts.Completions and into ts.Completions.PathCompletions. It also simplifies function isFunction to delegate to isFunctionLikeKind for most cases.

@ghost ghost closed this Mar 1, 2017
@ghost ghost deleted the path_completions branch March 1, 2017 16:31
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants