-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Refactor findAllReferences. Now supports renamed exports and imports. #14001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0f57e97
to
231cfbc
Compare
c7f473e
to
5cb2800
Compare
5cb2800
to
151023c
Compare
…indReferencedSymbols and getImplementationsAtPosition to return different results
Some comments:
|
709483f
to
28a3604
Compare
… at every possible position.
Should be in 28a3604 |
Don't think there was an issue for this but was mentioned here: #13643 (comment).
Fixes #13663.
Update: Now also fixes #10894.
Update: Fixes #14103.
We now use an algorithm to search for imports of a given export. This is in the new
importTracker.ts
. Previously we would just globally search for identifiers with the same name.Note: This breaks find-all-refs for untyped modules since we want to match the symbol and not just the name. See #14002.