Skip to content

Remove LightGBMBooster's mergeModels function #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhamilton723 merged 2 commits into from
Jun 19, 2018
Merged

Remove LightGBMBooster's mergeModels function #316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc68095
Remove LightGBMBooster's mergeModels function
Jun 12, 2018
e0d7a7f
Merge branch 'master' into RemoveMerge
Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/lightgbm/src/main/scala/LightGBMBooster.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,16 +130,6 @@ class LightGBMBooster(val model: String) extends Serializable {
lightgbmlib.voidpp_value(boosterOutPtr)
}

def mergeModels(newModel: LightGBMBooster): LightGBMBooster = {
// Merges models to first handle
if (model != null) {
LightGBMUtils.validate(
lightgbmlib.LGBM_BoosterMerge(getModel(), newModel.getModel()),
"Booster merge")
}
new LightGBMBooster(model)
}

def saveNativeModel(session: SparkSession, filename: String): Unit = {
if (filename == null || filename.isEmpty()) {
throw new IllegalArgumentException("filename should not be empty or null.")
Expand Down