Skip to content

Comments

Remove LightGBMBooster's mergeModels function#316

Merged
mhamilton723 merged 2 commits intomicrosoft:masterfrom
ywskycn:RemoveMerge
Jun 19, 2018
Merged

Remove LightGBMBooster's mergeModels function#316
mhamilton723 merged 2 commits intomicrosoft:masterfrom
ywskycn:RemoveMerge

Conversation

@ywskycn
Copy link
Contributor

@ywskycn ywskycn commented Jun 12, 2018

Discussed in #315, the merge function doesn't need anymore. Would better to remove it.

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@microsoft microsoft deleted a comment from mmlspark-bot Jun 14, 2018
@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@ywskycn
Copy link
Contributor Author

ywskycn commented Jun 16, 2018

@imatiach-msft @mhamilton723 know how to make the build-pr happy? :)

@imatiach-msft
Copy link
Contributor

@ywskycn yes, sorry, there was a major refactor that @mhamilton723 recently did to use Azure Databricks cluster for our tests instead of HDInsight and now it looks like the e2e builds are getting stuck, he is looking into it. The PR will be checked in as soon as the build issue is resolved, sorry for the inconvenience.

@mhamilton723
Copy link
Contributor

Sorry @ywskycn this is not your issue and I will check this in as soon as I iron out the build kinks, hopefully by tomorrow. If this is a blocker please let us know

@mhamilton723
Copy link
Contributor

@ywskycn could you quickly rebase your changes on latest master so we can push it through the new build? Thanks!

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (e0d7a7fe)

MMLSpark 0.12.dev20+2.ge0d7a7f

This is a build for Github PR #316, changes:


@mhamilton723 mhamilton723 merged commit 1ecd1d4 into microsoft:master Jun 19, 2018
@ywskycn ywskycn deleted the RemoveMerge branch June 19, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants