Skip to content

Fixed toggle switch not working issue. #41049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yeelam-gordon merged 5 commits into from
Aug 8, 2025
Merged

Fixed toggle switch not working issue. #41049

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6038b49
Fixed toggle switch not working issue.
shuaiyuanxx Aug 8, 2025
2e00f3e
update
shuaiyuanxx Aug 8, 2025
fc29e32
update
shuaiyuanxx Aug 8, 2025
b743eaa
update
shuaiyuanxx Aug 8, 2025
bb1a85c
update
shuaiyuanxx Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions src/settings-ui/Settings.UI/ViewModels/DashboardViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,18 @@ public DashboardViewModel(ISettingsRepository<GeneralSettings> settingsRepositor
private void AddDashboardListItem(ModuleType moduleType)
{
GpoRuleConfigured gpo = ModuleHelper.GetModuleGpoConfiguration(moduleType);
AllModules.Add(new DashboardListItem()
var newItem = new DashboardListItem()
{
Tag = moduleType,
Label = resourceLoader.GetString(ModuleHelper.GetModuleLabelResourceName(moduleType)),
IsEnabled = gpo == GpoRuleConfigured.Enabled || (gpo != GpoRuleConfigured.Disabled && ModuleHelper.GetIsModuleEnabled(generalSettingsConfig, moduleType)),
IsLocked = gpo == GpoRuleConfigured.Enabled || gpo == GpoRuleConfigured.Disabled,
Icon = ModuleHelper.GetModuleTypeFluentIconName(moduleType),
EnabledChangedCallback = EnabledChangedOnUI,
DashboardModuleItems = GetModuleItems(moduleType),
});
};

AllModules.Add(newItem);
newItem.EnabledChangedCallback = EnabledChangedOnUI;
}

private void EnabledChangedOnUI(DashboardListItem dashboardListItem)
Expand Down Expand Up @@ -120,16 +122,18 @@ private void GetShortcutModules()

if (filteredItems.Count != 0)
{
ShortcutModules.Add(new DashboardListItem
var newItem = new DashboardListItem
{
EnabledChangedCallback = x.EnabledChangedCallback,
Icon = x.Icon,
IsLocked = x.IsLocked,
Label = x.Label,
Tag = x.Tag,
IsEnabled = x.IsEnabled,
DashboardModuleItems = new ObservableCollection<DashboardModuleItem>(filteredItems),
});
};

ShortcutModules.Add(newItem);
newItem.EnabledChangedCallback = x.EnabledChangedCallback;
}
}

Expand All @@ -141,16 +145,18 @@ private void GetShortcutModules()

if (filteredItems.Count != 0)
{
ActionModules.Add(new DashboardListItem
var newItem = new DashboardListItem
{
EnabledChangedCallback = x.EnabledChangedCallback,
Icon = x.Icon,
IsLocked = x.IsLocked,
Label = x.Label,
Tag = x.Tag,
IsEnabled = x.IsEnabled,
DashboardModuleItems = new ObservableCollection<DashboardModuleItem>(filteredItems),
});
};

ActionModules.Add(newItem);
newItem.EnabledChangedCallback = x.EnabledChangedCallback;
}
}
}
Expand Down