Fixed toggle switch not working issue.#41049
Merged
yeelam-gordon merged 5 commits intomicrosoft:mainfrom Aug 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a toggle switch functionality issue by reordering the assignment of the EnabledChangedCallback property in two object initializers within the DashboardViewModel class. The callback assignment is moved from before the IsEnabled property to after the DashboardModuleItems property.
Key Changes
- Moved
EnabledChangedCallbackassignment to occur afterIsEnabledandDashboardModuleItemsproperties in object initializers
yeelam-gordon
added
the
Product-Settings
yeelam-gordon
approved these changes
Aug 8, 2025
yeelam-gordon
approved these changes
Aug 8, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Shuai Yuan <shuai.yuan.zju@gmail.com>
yeelam-gordon
force-pushed
the
shawn/fixSettingsToggleSwitch
branch
from
b5d4e08 to
bb1a85c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixed toggle switch not working issue.
AI Summary
This pull request refactors how
DashboardListItemobjects are created and added to collections in theDashboardViewModel. The main improvement is to separate the instantiation of eachDashboardListItemfrom the assignment of itsEnabledChangedCallbackproperty, which is now set after the object is added to the relevant collection. This change improves clarity and may help prevent issues related to object initialization order.Refactoring of
DashboardListItemcreation and initialization:AddDashboardListItemmethod, theDashboardListItemobject is now created and added toAllModulesbefore itsEnabledChangedCallbackproperty is set, instead of setting this property during object initialization.GetShortcutModulesmethod, bothShortcutModulesandActionModulescollections now receiveDashboardListItemobjects that are instantiated first, added to the collection, and then have theirEnabledChangedCallbackproperty set. This replaces the previous pattern of setting the callback during object creation. [1] [2]PR Checklist
Detailed Description of the Pull Request / Additional comments
It is an regression from #40214
Validation Steps Performed