[Color picker utility]: Incorrect method of keyboard navigation observed on Color picker utility dialogue on 'Pick color from screen', 'Close'

[Priyanshu073]

Microsoft PowerToys version

0.45.0

Running as admin

• Yes

Area(s) with issue?

ColorPicker

Steps to reproduce

Test Environment:
OS: Windows 11 Version Dev (22454.1000)
App version: 0.45.0
App name: Power Toys
Screen Reader: Narrator

Repro Steps:

1. Launch 'Power Toys' application.
2. Launch color picker utility using shortcut hotkeys, i.e. 'Ctrl+ Shift+ Y'.
3. Select any color on screen, and navigate to color picker utility dialogue.
4. Navigate to the controls using keyboard and observe the issue.

User Impact:
If at least one sequence of the content that makes sense is not programmatically determined, it may confuse or disorient users when assistive technology reads the content in the wrong order, or when alternate style sheets or other formatting changes are applied.

Guidelines Reference:
https://www.w3.org/WAI/WCAG21/Understanding/meaningful-sequence.html

Wcag.1.3.2.-Incorrect.method.of.keyboard.navigation.observed.on.Color.picker.utility.dialogue.on.Pick.color.from.screen.Close.Copy.from.clipboard.and.other.controls.mp4

✔️ Expected Behavior

Keyboard focus indicator should move in a logical and meaningful manner while navigating using keyboard. Expected behavior will be:

• Keyboard focus should not move to 'Copy to clipboard' button using down arrow keys from the darkest shade control. It should only navigate when user pressed tab key to navigate further.
• Focus should either navigate to Color history buttons form 'Pick a color from screen' button using tab and Shift+ tab key and not with arrow keys or it should move both ways up and down using arrow keys.
• Keyboard focus should navigate to Close dialogue button.
• On pressing left/ right arrow keys from lightest and darkest color shade pallet controls focus should either move to the lightest or darkest color or it should remain on the same control itself(recommended).

❌ Actual Behavior

Incorrect method of keyboard navigation observed on Color picker utility dialogue on 'Pick color from screen', 'Close', 'Copy from clipboard' and other controls. The issues were as follows:

• Keyboard focus moves to 'Copy to clipboard' button using down arrow keys from the darkest shade control.
• Focus navigates to Color history buttons form 'Pick a color from screen' button using down arrow key.
• Keyboard focus does not navigate to Close dialogue button.
• On pressing left/ right arrow keys from lightest and darkest color shade pallet controls focus moves to color history pane.

Other Software

No response

[stefansjfw]

Keyboard focus should navigate to Close dialogue button.

Although Close button looks like it's custom (as it's in line with pick color button and next to Settings button - next release, shown bellow), Close button is default window's close (X) button. Therefore it can't be navigated by keyboard from within the window.

Not sure if it's really an issue. Any thoughts?

[ghost]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

[stefansjfw]

Partially done:

• Navigation fixed
• Close button is default window's close (X) button. Therefore it can't be navigated by keyboard from within the window.

[ghost]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

[crutkas]

@stefansjfw as far as we're concerned, this has been fixed, correct? The default window X isn't our issue as it is part of the core window and can't be tabbed to.

This was resolved in .49, correct?

[stefansjfw]

@crutkas Yes, that's correct.