Skip to content

Fix few bugs related to some flow steps (connect, create envelope from template, list recipients) #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 15, 2022
Merged

Fix few bugs related to some flow steps (connect, create envelope from template, list recipients) #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e73c710
New schema changs for connec 2.0 json sim
sriharip-docusign May 18, 2022
65039e3
Update model to recognize Connect SIM 2.0 format
sriharip-docusign May 19, 2022
bea72d8
Merge branch 'microsoft:dev' into hotfix-flow-143
sriharip-docusign May 19, 2022
b15e187
add custom fields to the webhook response model
sriharip-docusign May 20, 2022
7fd9292
Update webhook response transformation logic for connect 2.0 json sim…
sriharip-docusign May 23, 2022
377d333
Merge pull request #2 from sriharip-docusign/hotfix-flow-143
sriharip-docusign May 24, 2022
c1deb96
Merge branch 'microsoft:dev' into dev
sriharip-docusign May 26, 2022
5fd8ecf
Merge branch 'microsoft:dev' into dev
sriharip-docusign Jun 2, 2022
2cb1004
Merge branch 'microsoft:dev' into dev
sriharip-docusign Jun 8, 2022
2e6154b
Add sender info in the parsed fields of Connect
sriharip-docusign Jun 9, 2022
5fb0d63
Disable navigation items from showing as part of available fields
sriharip-docusign Jun 10, 2022
e09b450
FLOW-154: Envelope Status is missing in Send Envelope using template …
sriharip-docusign Jun 14, 2022
497b48f
FLOW-155: The List recipients and Remove Recipient custom action does…
sriharip-docusign Jun 15, 2022
84beaf3
Undo changes to the visibility of parent elements in connect response
sriharip-docusign Jun 15, 2022
2fec22e
Merge branch 'microsoft:dev' into hotfix_bugs
sriharip-docusign Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 41 additions & 24 deletions certified-connectors/DocuSignDemo/apiDefinition.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,20 @@
},
"type": "string"
},
{
"name": "status",
"in": "query",
"description": "Envelope status",
"required": true,
"x-ms-summary": "Envelope status",
"x-ms-test-value": "Created",
"x-ms-visibility": "important",
"type": "string",
"enum": [
"Sent",
"Created"
]
},
{
"name": "signers",
"in": "body",
Expand Down Expand Up @@ -1366,13 +1380,10 @@
"allUsers",
"allowEnvelopePublish",
"includeDocumentFields",
"includeEnvelopeVoidReason",
"includeTimeZoneInformation",
"requiresAcknowledgement",
"urlToPublishTo",
"name",
"envelopeEvents",
"includeSenderAccountasCustomField"
"envelopeEvents"
],
"type": "object",
"properties": {
Expand All @@ -1394,18 +1405,6 @@
"x-ms-summary": "includeDocumentFields",
"x-ms-visibility": "internal"
},
"includeEnvelopeVoidReason": {
"default": "true",
"type": "string",
"x-ms-summary": "includeEnvelopeVoidReason",
"x-ms-visibility": "internal"
},
"includeTimeZoneInformation": {
"default": "true",
"type": "string",
"x-ms-summary": "includeTimeZoneInformation",
"x-ms-visibility": "internal"
},
"requiresAcknowledgement": {
"default": "true",
"type": "string",
Expand Down Expand Up @@ -1434,12 +1433,6 @@
"type": "string",
"x-ms-summary": "Envelope event",
"x-ms-visibility": "important"
},
"includeSenderAccountasCustomField": {
"default": "true",
"type": "string",
"x-ms-summary": "includeSenderAccountasCustomField",
"x-ms-visibility": "internal"
}
}
},
Expand All @@ -1450,7 +1443,6 @@
"type": "object",
"properties": {
"envelopeSummary": {
"description": "EnvelopeStatus",
"type": "object",
"properties": {
"customFields": {
Expand Down Expand Up @@ -1488,9 +1480,34 @@
},
"emailSubject": {
"type": "string",
"x-ms-summary": "Subject",
"x-ms-summary": "Email Subject",
"x-ms-visibility": "important"
},
"sender": {
"type": "object",
"properties": {
"userName": {
"type": "string",
"x-ms-summary": "Sender's Name",
"x-ms-visibility": "important"
},
"userId": {
"type": "string",
"x-ms-summary": "Sender's User ID",
"x-ms-visibility": "important"
},
"accountId": {
"type": "string",
"x-ms-summary": "Sender's Account ID",
"x-ms-visibility": "important"
},
"email": {
"type": "string",
"x-ms-summary": "Sender's Email Address",
"x-ms-visibility": "important"
}
}
},
"recipients": {
"type": "object",
"properties": {
Expand Down
28 changes: 28 additions & 0 deletions certified-connectors/DocuSignDemo/script.csx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,11 @@ public class Script : ScriptBase
["templateId"] = query.Get("templateId")
};

if (!string.IsNullOrEmpty(query.Get("status")))
{
newBody["status"] = query.Get("status");
}

var uriBuilder = new UriBuilder(this.Context.Request.RequestUri);
uriBuilder.Path = uriBuilder.Path.Replace("envelopes/createFromTemplate", "/envelopes");
this.Context.Request.RequestUri = uriBuilder.Uri;
Expand Down Expand Up @@ -696,6 +701,15 @@ public class Script : ScriptBase
this.Context.Request.RequestUri = uriBuilder.Uri;
}

if ("GetFolderEnvelopeList".Equals(this.Context.OperationId, StringComparison.OrdinalIgnoreCase))
{
var uriBuilder = new UriBuilder(this.Context.Request.RequestUri);
var query = HttpUtility.ParseQueryString(this.Context.Request.RequestUri.Query);
query["include_items"] = "true";
uriBuilder.Query = query.ToString();
this.Context.Request.RequestUri = uriBuilder.Uri;
}

// update Accept Header
this.Context.Request.Headers.Accept.Clear();
var acceptHeaderValue = "application/json";
Expand Down Expand Up @@ -803,6 +817,20 @@ public class Script : ScriptBase
response.Headers.RetryAfter = new RetryConditionHeaderValue(TimeSpan.FromSeconds(120));
}

if ("GetFolderEnvelopeList".Equals(this.Context.OperationId, StringComparison.OrdinalIgnoreCase))
{
var body = ParseContentAsJObject(await response.Content.ReadAsStringAsync().ConfigureAwait(false), false);
var newBody = new JObject();

foreach (var folder in (body["folders"] as JArray) ?? new JArray())
{
newBody = folder as JObject;
break;
}

response.Content = new StringContent(newBody.ToString(), Encoding.UTF8, "application/json");
}

if (response.Content?.Headers?.ContentType != null)
{
if ("GetDocuments".Equals(this.Context.OperationId, StringComparison.OrdinalIgnoreCase))
Expand Down