This repository was archived by the owner on Jul 19, 2024. It is now read-only.
Update Spectator View#271
Merged
keveleigh merged 57 commits intomicrosoft:masterfrom Jun 14, 2018
fieldsJacksonG:master
Merged
Conversation
…g when moving the camera. Remove cached IP in Unity project
-Clock synchronization and cached poses and color frames to find closest match. -Buffered texture fetches to improve video recording performance Update network to not lock when finding pose. Update SpectatorViewManager to accept a frame offset to account for variable latency in capture pipeline. Default to 3 frames, which seems to be BlackMagic's HDMI capture latency. Lifecycle bug fixes - all state should reset when we stop play-mode.
Photos are now using sRGB color space, previously were too bright. Use frame-based timestamp to normalize timestamp to frame rate - not doing this prevented OpenCV captures from recording correctly. Remove AdditionalTimeOffsetSeconds from SpectatorViewManager to reduce complexity/ confusion since FrameOffset does the same thing.
- Use latest IFrameProvider interface - Set output texture - force opaque frame buffers for non-yuv capture devices.
Update Elgato frame capture to work more reliably when calibrating.
Allow for debug calibration builds
…hile) x64 only, and SV DLLs now only run in the Editor. Add #if UNITY_EDITOR wrappers to SV code to ensure we only run in the editor.
currently anchors are not being shared successfully Once anchors are shared within Unity apps, will intercept in SV PoseProvider
…import the shared anchor. Update to 2017.4 since 2017.3 was not always sharing anchors successfully. Currently the anchor owner must have already started it's server, and the pose provider must know the IP and port.
…nges in its value.
Populate IPs from SharingToSVAdapter
… frequently. Send anchor name and force-reconnect flag to pose provider to check if a new anchor needs to be imported. Only send message to pose provider if an anchor needs to be reestablished.
…r) at hitpoint or 2 meters in front of HL
…g to a Unity transform.
… a new HoloLens joins. The anchor name and IP will both be sent to Unity to distribute to the SV device. NOTE: This is for the simple sharing presented in this demo project. A more robust sharing solution will keep track of the anchor owner and distribute to all clients.
…alues have somehow corrupted.
keveleigh
reviewed
May 24, 2018
| Temp/* | ||
|
|
||
| # dlls | ||
| Assets/Addons/SpectatorViewRig/Plugins/WSA/x64/* |
Contributor
Author
There was a problem hiding this comment.
Nope - SV used to require building and deploying the app to the SV HoloLens, now it interfaces with SpectatorViewPoseProvider.
keveleigh
previously approved these changes
Jun 8, 2018
Contributor
|
@fieldsJacksonG There are merge conflicts. |
This was referenced Jun 8, 2018
Contributor
|
Hey, separating the network code from the logic will be extremely useful. And the fact of not having to deploy a build of the app to the headset fastened to the camera rig will be really helpful |
…tyCompanionKit into fieldsJacksonG-master
Updating with latest master
keveleigh
approved these changes
Jun 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #179, fixes #213, fixes #218, fixes #231, fixes #239, fixes #262