Skip to content

Do not store explicit versions in the build properties #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not store explicit versions in the build properties #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,6 @@

<PropertyGroup>
<OutputPath>$(StagingOutputRootPath)$(MSBuildProjectName)\</OutputPath>
<VCToolsVersion>14.15.26726</VCToolsVersion>
<WindowsTargetPlatformVersion>10.0.16299.0</WindowsTargetPlatformVersion>
<PlatformToolset>v141</PlatformToolset>
<OutDir>$(OutputPath)</OutDir>
<O>$(Platform)\$(Configuration)</O>
<O Condition="'$(Platform)' == 'x86'">$(Configuration)</O>
Expand Down
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,11 @@ Earlier versions of MS-MPI are available from the [Microsoft Download Center](ht
- Update _GFORTRAN_BIN_ in Derectory.Build.props to the install location of GFortran
- [Perl](https://www.perl.org/get.html#win32)

Based on the installed VS/SDK/WDK versions, update _VCToolsVersion_ and _WindowsTargetPlatformVersion_ in Directory.Build.props

Note that the build system uses [CommonBuildToolSet(CBT)](https://commonbuildtoolset.github.io/). You may need to unblock __CBT.core.dll__ (under .build/CBT) depending on your security configurations. Please refer to [CBT documentation](https://commonbuildtoolset.github.io/#/getting-started) for additional details.


## Build
To build, open a __Native Tools Command Prompt for Visual Studio__ and run ``msbuild`` from root folder.
To build, open a __Native Tools Command Prompt for Visual Studio__ and run ``msbuild /p:WindowsTargetPlatformVersion=<WindowsTargetPlatformVersion> /p:PlatformToolset=<PlatformToolset>`` from root folder, where `<WindowsTargetPlatformVersion>` and `<PlatformToolset>` should be selected based on your installed VS/SDK/WDK versions.

# Contributing

Expand Down