Validate the configuration produced by LlamaTune inverse_transform() #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are mainly to add flexibility to the auth service in supporting azure authenticating via: - A personal identity via az CLI for the local dev environment. This will still run into expiring issues, but is probably fine for local dev. - A personal or managed identity in an azure hosted environment. The flexibility to use the managed identity allows us to avoid the expiring issue without needing a separate SP, key-vault and cert setup, aligning with new security recommendations. --------- Co-authored-by: Eu Jing Chua <eujingchua@microsoft.com> Co-authored-by: Sergiy Matusevych <sergiym@microsoft.com>
Mypy got updated to v 1.11 recently We need these mypy fixes to make other PRs pass the CI tests
Closes microsoft#785 Also, add more unit tests to make sure the optimizer handles string inputs correctly. --------- Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
…sergiym/opt/llamatune_inv
Contributor
Author
|
@kkanellis please have a look at this when you get a chance. Pretty sure the clipping is the appropriate thing to do, but another set of eyes would be good. Thanks! |
bpkroth
commented
Jul 23, 2024
bpkroth
commented
Jul 23, 2024
motus
reviewed
Jul 23, 2024
motus
reviewed
Jul 29, 2024
motus
reviewed
Jul 29, 2024
motus
approved these changes
Jul 29, 2024
Member
motus
left a comment
motus
left a comment
There was a problem hiding this comment.
pushed a few small fixes; will merge into master and of @kkanellis has some updates, we'll do it in the subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp of #806 with the fix as well.
Adds code to handle appropriate scaling and type conversion and checking of the inverted config.
Splits that code out to a separate method for individual configs to make pylint happy and improve code readability.