Fix the coercion of scores to floats in the optimizer #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motus
added
bug
bpkroth
reviewed
Jul 10, 2024
bpkroth
reviewed
Jul 11, 2024
bpkroth
reviewed
Jul 11, 2024
mlos_bench/mlos_bench/tests/optimizers/mlos_core_opt_df_test.py
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Jul 11, 2024
bpkroth
reviewed
Jul 11, 2024
mlos_bench/mlos_bench/tests/optimizers/mlos_core_opt_df_test.py
Outdated
Show resolved
Hide resolved
bpkroth
changed the title
…into sergiym/opt/score_sign
…/opt/score_sign
…/opt/score_sign
…into sergiym/opt/score_sign
…/opt/score_sign
…into sergiym/opt/score_sign
…/opt/score_sign
bpkroth
reviewed
Jul 22, 2024
bpkroth
approved these changes
Jul 22, 2024
Contributor
bpkroth
left a comment
bpkroth
left a comment
There was a problem hiding this comment.
Minor comment about a test and pylint protected access complaints vs. public method test. Otherwise, LGTM :)
bpkroth
added a commit
to bpkroth/MLOS
that referenced
this pull request
Jul 22, 2024
Closes microsoft#785 Also, add more unit tests to make sure the optimizer handles string inputs correctly. --------- Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #785
Also, add more unit tests to make sure the optimizer handles string inputs correctly.