Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove only cpu note due to gpu support for linear trees #6686

Merged
merged 5 commits into from
Oct 25, 2024
Merged

[docs] Remove only cpu note due to gpu support for linear trees #6686

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e351bea
Remove only cpu note
JAroyan Oct 18, 2024
131e67b
Change Note for linear tree
JAroyan Oct 18, 2024
fb55d08
Merge branch 'master' into doc_linear_tree
StrikerRUS Oct 21, 2024
41ad501
Merge branch 'master' into doc_linear_tree
jameslamb Oct 22, 2024
4846019
Merge branch 'master' into doc_linear_tree
jameslamb Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/Parameters.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ Dataset Parameters

- it is recommended to rescale data before training so that features have similar mean and standard deviation

- **Note**: works only with ``cpu`` device type and ``serial`` tree learner
- **Note**: works only with ``serial`` tree learner
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about cuda device type.

Suggested change
- **Note**: works only with ``serial`` tree learner
- **Note**: works only with ``cpu``, ``gpu`` device type and ``serial`` tree learner

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification @StrikerRUS !
I added cpu and gpu as device type and did not added cuda as device type.
As far as I could understand from the pull request, device type cuda is not yet supported or?
The parameter-generator.py. run worked well!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

As far as I could understand from the pull request, device type cuda is not yet supported or?

Yes, I have the same opinion.


- **Note**: ``regression_l1`` objective is not supported with linear tree boosting

Expand Down