[docs] Remove only cpu note due to gpu support for linear trees #6686
Conversation
JAroyan
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
JAroyan
changed the title
There was a problem hiding this comment.
Thanks for your contribution @JAroyan !
This file is automatically generated and isn't intended to be edited manually.
You should edit this file:
LightGBM/include/LightGBM/config.h
Line 667 in c7d3ac1
and then run the following helper script: https://github.com/microsoft/LightGBM/blob/master/.ci/parameter-generator.py.
docs/Parameters.rst
Outdated
| @@ -795,7 +795,7 @@ Dataset Parameters | |||
|
|
|||
| - it is recommended to rescale data before training so that features have similar mean and standard deviation | |||
|
|
|||
| - **Note**: works only with ``cpu`` device type and ``serial`` tree learner | |||
| - **Note**: works only with ``serial`` tree learner | |||
There was a problem hiding this comment.
Don't forget about cuda device type.
| - **Note**: works only with ``serial`` tree learner | |
| - **Note**: works only with ``cpu``, ``gpu`` device type and ``serial`` tree learner |
There was a problem hiding this comment.
Thank you for the clarification @StrikerRUS !
I added cpu and gpu as device type and did not added cuda as device type.
As far as I could understand from the pull request, device type cuda is not yet supported or?
The parameter-generator.py. run worked well!
There was a problem hiding this comment.
Thank you!
As far as I could understand from the pull request, device type cuda is not yet supported or?
Yes, I have the same opinion.
jameslamb
changed the title
There was a problem hiding this comment.
LGTM!
Please agree with CLA by following instructions from #6686 (comment). After that we'll be able to merge your PR.
StrikerRUS
changed the title
|
@microsoft-github-policy-service agree |
I updated the documentation note of 'linear_tree' due to the introduced support of 'device_type=gpu' in pull request (#6555).