Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][R-package] run R CRAN checks on Solaris by optional workflow #3913
[ci][R-package] run R CRAN checks on Solaris by optional workflow #3913
Changes from 10 commits
e90493b
a519afc
91eeb7e
9178dec
7495011
d087f0a
6b39c90
5fd9f0f
d4a1c83
cd60516
a41cd14
5e034a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found any documentation on how often these tokens expire. But from my experience, I've found that about once every 6 weeks, I have to re-validate my email with R Hub. I don't know the rules for when and why validation is revoked, so I don't know for sure if hard-coding a token here is a problem.
I'm fine with leaving this here and seeing how it goes, but let's watch it carefully because base don my experience with R Hub, I expect we'll have to have a PR every two months or so to update this token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's leave this token here, I don't mind.
Let's hope that nobody will abuse RHub with our public e-mail address and publicly available token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want in a follow-up PR, you could make it a GitHub Secret (https://docs.github.com/en/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow, mentioned in https://github.com/StrikerRUS/LightGBM/pull/3#issuecomment-772893909), set that as an environment variable, and read it in with
Sys.getenv()
. Then no one will see it in plain text.Can be a later PR though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check how often we will have to update this token first. If not so often, then I'll ask you to add new token as a repo secret before preparing a new PR because I don't have an access for doing this.
But right after merging this PR there will be a small follow-up one with new e-mail/token (because these ones were for testing) and check that everything is working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. Sorry, I missed sone of your comments and I created confusion because of it. I also do not have permission #3913 (comment)
but I'm fine leaving this in for now