[ci][R-package] run R CRAN checks on Solaris by optional workflow #3913
Conversation
.ci/run_rhub_solaris_checks.R
Outdated
| ) | ||
| rhub::validate_email( | ||
| email = intToUtf8(email - 42L) | ||
| , token = '6bc89147c8fc4824bce09f8454e4ab8e' |
There was a problem hiding this comment.
This is a test token to test e-mail.
@jameslamb Can I send you a production token (in Slack, for example) and you will place new token in GitHub Repository Secrets and tell me name of new secret (something like RHUB_EMAIL_TOKEN)?
There was a problem hiding this comment.
ah I'm sorry, I didn't see this comment yesterday either!! It seems like I missed several of your comments. Maybe because I was looking on the "files" tab and these were on lines in the diff that had changed or something.
I would be happy to help, but I do not have permission on this repo to create secrets. I think only @guolinke can do that
There was a problem hiding this comment.
I noticed that all the comments I missed are on parts of the diff that say "outdated", so guess it is a GitHub UI thing
There was a problem hiding this comment.
OK, no problem! Let's start with plain token in the source code, I think.
.ci/run_rhub_solaris_checks.R
Outdated
| } | ||
| } | ||
| for (note in notes) { | ||
| note = iconv(note, "UTF-8", "ASCII", sub="") |
There was a problem hiding this comment.
iconv() to remove non-ASCII quotes around march=pentiumpro.
https://stackoverflow.com/a/38184834
https://stackoverflow.com/a/17292126
.github/workflows/r_solaris.yml
Outdated
| jobs: | ||
| test: | ||
| name: solaris-cran | ||
| timeout-minutes: 60 |
There was a problem hiding this comment.
I run 20+ different checks on various platforms. All of them either finished within around 20 minutes or were aborted on RHub side (whole build took 44 minutes in that case):
3527#> * checking for unstated dependencies in ‘tests’ ... OK
3528#> * checking tests ...
3529#> Running ‘testthat.R’Build timed out (after 20 minutes). Marking the build as failed.
3530#> Build was aborted
There was a problem hiding this comment.
I'm surprised, but glad to hear it! I have had experiences before where I submit a job on a less-common platform like Solaris and it runs overnight (maybe 10 hours from submission to result)
There was a problem hiding this comment.
Maybe there were no timeouts on Rhub before?.. I don't know... You can check "Submitted:" and "Build time:" lines in all e-mails in http://www.yopmail.com/lightgbm_test_email to check response time.
| ) | ||
| rhub::validate_email( | ||
| email = intToUtf8(email - 42L) | ||
| , token = "6bc89147c8fc4824bce09f8454e4ab8e" |
There was a problem hiding this comment.
I haven't found any documentation on how often these tokens expire. But from my experience, I've found that about once every 6 weeks, I have to re-validate my email with R Hub. I don't know the rules for when and why validation is revoked, so I don't know for sure if hard-coding a token here is a problem.
I'm fine with leaving this here and seeing how it goes, but let's watch it carefully because base don my experience with R Hub, I expect we'll have to have a PR every two months or so to update this token.
There was a problem hiding this comment.
OK, let's leave this token here, I don't mind.
Let's hope that nobody will abuse RHub with our public e-mail address and publicly available token.
There was a problem hiding this comment.
if you want in a follow-up PR, you could make it a GitHub Secret (https://docs.github.com/en/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow, mentioned in https://github.com/StrikerRUS/LightGBM/pull/3#issuecomment-772893909), set that as an environment variable, and read it in with Sys.getenv(). Then no one will see it in plain text.
Can be a later PR though
There was a problem hiding this comment.
Let's check how often we will have to update this token first. If not so often, then I'll ask you to add new token as a repo secret before preparing a new PR because I don't have an access for doing this.
But right after merging this PR there will be a small follow-up one with new e-mail/token (because these ones were for testing) and check that everything is working as expected.
There was a problem hiding this comment.
sounds good. Sorry, I missed sone of your comments and I created confusion because of it. I also do not have permission #3913 (comment)
but I'm fine leaving this in for now
|
Looks fine, please |
|
@jameslamb I hope I addressed all your comments from previous review in 5e034a0 or gave my comment in the corresponding thread above. |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Refer to #3740.
How it looks like: https://github.com/StrikerRUS/LightGBM/pull/5#issuecomment-773700926.