Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] remove broken default for file in readRDS / saveRDS functions #3664

Merged
merged 8 commits into from
Jan 3, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[R-package] remove broken default file in readRDS / saveRDS functions
  • Loading branch information
jameslamb committed Dec 20, 2020
commit 41e6224eee25d51a37098e625ed0323f4ae2ef91
8 changes: 6 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,9 @@ python-package/lightgbm/VERSION.txt
**/autom4te.cache/
conftest*
R-package/config.status
!R-package/data/agaricus.test.rda
!R-package/data/agaricus.train.rda
!R-package/data/bank.rda
R-package/docs
R-package/src/CMakeLists.txt
R-package/src/Makevars
Expand All @@ -422,16 +425,17 @@ miktex*.zip

# Files created by R examples and tests
**/lgb-Dataset.data
**/lgb-model.rds
**/lgb.Dataset.data
**/model.rds
**/model.txt
**/lgb-model.txt

# Files from interactive R sessions
.Rproj.user
**/.Rapp.history
**/.Rhistory
*.rda
*.RData
*.rds

# Files generated by aspell
**/*.bak
Expand Down
2 changes: 1 addition & 1 deletion R-package/R/readRDS.lgb.Booster.R
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#' new_model <- readRDS.lgb.Booster(model_file)
#' }
#' @export
readRDS.lgb.Booster <- function(file = "", refhook = NULL) {
readRDS.lgb.Booster <- function(file, refhook = NULL) {

object <- readRDS(file = file, refhook = refhook)

Expand Down
2 changes: 1 addition & 1 deletion R-package/R/saveRDS.lgb.Booster.R
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
#' }
#' @export
saveRDS.lgb.Booster <- function(object,
file = "",
file,
ascii = FALSE,
version = NULL,
compress = TRUE,
Expand Down
2 changes: 1 addition & 1 deletion R-package/man/readRDS.lgb.Booster.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion R-package/man/saveRDS.lgb.Booster.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.