[R-package] remove broken default for file
in readRDS / saveRDS functions
#3664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
readRDS.lgb.Booster()
andsaveRDS.lgb.Booster()
in the R package take a keyword argumentfile
, which indicates the.rds
file to use.Those functions use default
file = ""
, but this isn't a valid value for that parameter.readRDS.lgb.Booster()
:saveRDS.lgb.Booster(list(raw = 1))
This PR proposes just removing the default value, and forcing users to choose a filepath. I think this is preferable to changing the default value to something like
"model.rds"
, because it makes code using these functions more explicit, and thus less at risk of errors.While testing this, I created some
.rds
files and noticed they weren't ignore bygit
. This PR also changes.gitignore
to ignore R's binary formats (.rda
,.rds
,.RData
) so such files aren't accidentally checked into source control.