Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected APIs marked with @internal for SharedMap and Counter #7521

Merged
merged 9 commits into from
Sep 28, 2021
Merged

Protected APIs marked with @internal for SharedMap and Counter #7521

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
caa0e50
Mark map protected apis internal
skylerjokiel Sep 17, 2021
ce6320e
add @internal to counter
skylerjokiel Sep 17, 2021
b6be856
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
skylerjokiel Sep 19, 2021
54341bf
remove an extra file and fix some api exports
skylerjokiel Sep 19, 2021
a0603c3
revert two packages
skylerjokiel Sep 19, 2021
475a747
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
skylerjokiel Sep 20, 2021
ecf57c8
add @internal to protected methods
scottn12 Sep 24, 2021
92c2b8d
implement @internal in dds src files, rebuilt api report files
scottn12 Sep 28, 2021
c40d14b
fix linting issues
scottn12 Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add @internal to counter
  • Loading branch information
@skylerjokiel
skylerjokiel committed Sep 17, 2021
commit ce6320e043dbecafc7b0451bbb0569163087a903
1 change: 1 addition & 0 deletions packages/dds/counter/src/counter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ export class SharedCounter extends SharedObject<ISharedCounterEvents> implements
* @param local - whether the message was sent by the local client
* @param localOpMetadata - For local client messages, this is the metadata that was submitted with the message.
* For messages from a remote client, this will be undefined.
* @internal
*/
protected processCore(message: ISequencedDocumentMessage, local: boolean, localOpMetadata: unknown) {
if (message.type === MessageType.Operation && !local) {
Expand Down