Protected APIs marked with @internal for SharedMap and Counter
#7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
github-actions
bot
requested review from
vladsud and
anthony-murphy
and removed request for
a team
tylerbutler
approved these changes
Sep 18, 2021
api-report/map.api.md
Outdated
Comment on lines
173
to
174
| // Warning: (ae-forgotten-export) The symbol "LocalValueMaker" needs to be exported by the entry point index.d.ts | ||
| // |
There was a problem hiding this comment.
You need to export this type too.
api-report/map.api.md
Outdated
Comment on lines
192
to
193
| // Warning: (ae-forgotten-export) The symbol "IDirectoryOperation" needs to be exported by the entry point index.d.ts | ||
| // |
sumedhb1995
approved these changes
Sep 18, 2021
|
Build blocker is probably being caused by the package-lock and lerna-package-lock changes. Leaving those out of the PR should allow it to pass |
are we forcing npm 7? Refers to: package-lock.json:4 in ce6320e. [](commit_id = ce6320e, deletion_comment = False) |
github-actions
bot
removed
the
dependencies
…to protected-apis-to-internal
Prevent protected methods from showing up in public docs
github-actions
bot
added
area: framework
Broken link report 👍🏻🔗 No broken links found! ✅ Your attention to detail is admirable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding @internal prevents APIs from being on the public docs.