Skip to content

Conversation

@bob80905
Copy link
Collaborator

@bob80905 bob80905 commented Apr 4, 2025

This PR modifies WaveSizeRange test which depends on shader model 6.8.
The compiler needs -select-validator internal.
This will allow the tests to be run in different testing environments when an external validator that isn't sufficient is available.

Cherry pick of #7309

@damyanp
Copy link
Member

damyanp commented Apr 4, 2025

Do we need this in the short term? I wonder if the correct long term fix here is to make the internal validator the default, which is what the plan was all along.

@bob80905
Copy link
Collaborator Author

bob80905 commented Apr 4, 2025

Do we need this in the short term? I wonder if the correct long term fix here is to make the internal validator the default, which is what the plan was all along.

Unneeded in the short term as far as I'm concerned. But I imagine this PR would prevent similar issues if we decide to make a release before changing the internal validator default behavior.

@bob80905
Copy link
Collaborator Author

We're going to opt to change validation behavior entirely to resolve this.
According to #7389

@bob80905 bob80905 closed this Apr 29, 2025
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants