Skip to content

Use internal validator for execution test that requires SM 6.8 #7309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Use internal validator for execution test that requires SM 6.8 #7309

merged 1 commit into from
Apr 4, 2025

Conversation

@bob80905
Copy link
Collaborator

@bob80905 bob80905 commented Apr 4, 2025

This PR modifies WaveSizeRange test which depends on shader model 6.8.
The compiler needs -select-validator internal.
This will allow the tests to be run in different testing environments when an external validator that isn't sufficient is available.

@bob80905 bob80905 requested a review from a team as a code owner April 4, 2025 01:23
@damyanp damyanp requested a review from jenatali April 4, 2025 15:44
damyanp
damyanp approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all that's needed?

@jenatali
Copy link
Member

jenatali commented Apr 4, 2025

Is this all that's needed?

Technically all tests could be modified to use -select-validator internal to not require an external validator anywhere on the system, but the SM6.8 tests are the biggest problem right now since the latest released Windows SDK includes a validator that only supports SM6.7. So, yeah this is sufficient for the problems that we're seeing right now.

@bob80905 bob80905 merged commit 51635fd into microsoft:staging-sm6.9 Apr 4, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 4, 2025
@bob80905 bob80905 mentioned this pull request Apr 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damyanp damyanp damyanp approved these changes

@jenatali jenatali jenatali approved these changes

Assignees

No one assigned

Labels

None yet

Projects

HLSL Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bob80905 @jenatali @damyanp