Fixes for latest Huggingface_hub changes on modelId -> id #5789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekurile
approved these changes
Jul 22, 2024
|
Tested locally, the failure appears to be with the cached versions we keep, so going to force merge this PR. |
|
sorry about the breaking change on our side, and thanks for quickly pushing this fix ❤️ (we have reverted the change server side for now, but we plan to re-apply it in the future) |
Thanks @julien-c, we have made all changes to support the new field now, so we should be fine in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs in huggingface_hub that mirror this:
huggingface/huggingface_hub#2405