Do not use modelId + remove some self.assert #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
julien-c
approved these changes
Jul 22, 2024
This was referenced Jul 22, 2024
loadams
added a commit
to microsoft/DeepSpeed
that referenced
this pull request
Jul 22, 2024
PRs in huggingface_hub that mirror this: huggingface/huggingface_hub#2405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HfApi.model_info(...).modelIdis deprecated and used only in tests. Let's useHfApi.model_info(...).ideverywhere instead. cc @julien-c "Time to finally remove this, it's been long enough" (see https://github.com/huggingface-internal/moon-landing/pull/10713, private).Also took the opportunity to (non-exhaustively) switch some
self.asserttoassertin tests. All diff is semantically the same as before.