Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor check_enabled root validator in DeepSpeedMonitorConfig #3616

Merged
merged 7 commits into from
Jun 2, 2023
Merged

Refactor check_enabled root validator in DeepSpeedMonitorConfig #3616

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
38203d4
Refactor check_enabled root validator in DeepSpeedMonitorConfig
bgr8 May 26, 2023
112ab5a
Merge branch 'master' into patch-1
bgr8 May 29, 2023
4945259
Merge branch 'master' into patch-1
mrwyattii May 31, 2023
36272b2
formatting
mrwyattii Jun 1, 2023
f192d38
formatting
mrwyattii Jun 1, 2023
1a0c0b0
Merge branch 'master' into patch-1
mrwyattii Jun 1, 2023
5c10969
Merge branch 'master' into patch-1
mrwyattii Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions deepspeed/monitor/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,8 @@ class DeepSpeedMonitorConfig(DeepSpeedConfigModel):

csv_monitor: CSVConfig = {}
""" Local CSV output of monitoring data. """

@root_validator
def check_enabled(cls, values):
values["enabled"] = False
if (values.get("tensorboard").enabled or values.get("wandb").enabled or values.get("csv_monitor").enabled):
values["enabled"] = True
values["enabled"] = values.get("tensorboard").enabled or values.get("wandb").enabled or values.get("csv_monitor").enabled
return values