Refactor check_enabled root validator in DeepSpeedMonitorConfig #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrwyattii
approved these changes
May 31, 2023
|
Thank you @bgr8 |
molly-smith
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Refactor check_enabled root validator in DeepSpeedMonitorConfig * formatting * formatting --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Michael Wyatt <mrwyattii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify enabled check in root_validator
The updated root_validator in the
DeepSpeedMonitorConfigclass simplifies the logic by removing the redundant enabled check. Instead, it directly assigns the result of the condition tovalues["enabled"]. This change improves code readability and eliminates unnecessary code.