Skip to content

Conversation

@compulim
Copy link
Contributor

@compulim compulim commented Feb 27, 2022

Fixes #4170. Related to #4133.

Changelog Entry

Description

Polyfills for IE11

We introduced Map in #4108. However, we should also add the polyfill from core-js/features/map.

Test file name length

Some snapshots generated by Jest has too long filename that made the repository not cloneable on Windows.

We renamed some tests to make the snapshot filenames shorter.

Bumping dependencies

There was a bug in esbuild@<0.13.4 which caused it to fail on npm@7.

The newer version of these dependencies are using newer version of esbuild@0.14.23:

Design

Specific Changes

  • Renamed some tests to reduce length of file names
  • Refactor IE11 polyfills to separate file
  • Updated dependencies
  • Remove lerna.json and package.json under /samples/ as we no longer use lerna for samples for quite some time
  • Run npm audit fix under /samples/01.getting-started/g.hybrid-react-npm/
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim added the p0 Must Fix. Release-blocker label Mar 1, 2022
@compulim compulim marked this pull request as ready for review March 1, 2022 04:51
@compulim compulim merged commit 4623feb into microsoft:main Mar 2, 2022
@compulim compulim deleted the fix-ie11-polyfill branch March 2, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p0 Must Fix. Release-blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot clone project due to filename too long

2 participants