-
Couldn't load subscription status.
- Fork 1.6k
Bump Adaptive Cards to 2.10.0 #4074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the .devcontainer directory needed for this change?
|
Not exactly for bumping AC 2.10 or accessibility. But I included it for even-simpler GitHub Codespaces experience, i.e. it will |
Changelog Entry
Fixed
role="heading"to titles of rich card, by @compulim, in PR #4074Changed
@babel/runtime@7.15.4adaptivecards@2.10.0base64-arraybuffer@1.0.1core-js@3.18.3markdown-it-attrs-es5@2.0.1react-film@3.1.0react-say@2.1.0react-scroll-to-bottom@4.2.0@babel/cli@^7.15.7@babel/core@^7.15.8@babel/plugin-proposal-object-rest-spread@^7.15.6@babel/plugin-transform-runtime@^7.15.8@babel/preset-env@^7.15.8@babel/preset-typescript@^7.15.0@types/node@^16.10.9@types/react@^17.0.29@typescript-eslint/eslint-plugin@^4.33.0@typescript-eslint/parser@^4.33.0babel-jest@^27.2.5concurrently@^6.3.0core-js@^3.18.3esbuild@^0.12.29eslint-plugin-prettier@^3.4.1eslint-plugin-react@^7.26.1eslint@^7.32.0istanbul-lib-coverage@^3.0.2jest-environment-node@^27.2.5jest@^27.2.5node-fetch@^2.6.5prettier@^2.4.1restify@^8.6.0selenium-webdriver@^4.0.0serve@^12.0.1strip-ansi@^6.0.1terser-webpack-plugin@^5.2.4webpack-cli@^4.9.0webpack@^5.58.2Description
Bumping to Adaptive Cards 2.10, which support schema 1.5.
A new
TextBlock.stylewas added in AC schema 1.5 to support an accessibility feature: card title should haverole="heading".We are updating our rich card renderer on our side to support this feature and this is related to #4015.
Also, we are bumping all our dependencies.
Design
There should be no visual updates related to the
TextBlock.style = 'heading'.However, AC 2.10 updated its layout a bit. We are updating our tests to follow their new style. The follow screenshot is from
__tests__/adaptiveCards.js"container styles" test.After bump deps, all our peer deps should now support
react@17(i.e.react >= 16.8.6).Updated to
prettier@2.4, they renamedjsxBracketSameLinetobracketSameLine, https://prettier.io/blog/2021/09/09/2.4.0.html.Specific Changes
adaptivecards@2.10.0.prettierrc.ymlto usebracketSameLineoverjsxBracketSameLinedevcontainer.jsonfor GitHub CodespacesCHANGELOG.mdI have updated documentationReview Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)