Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rework app exit to account for running bots #9532

Merged
merged 16 commits into from
Apr 17, 2023
Merged

fix: rework app exit to account for running bots #9532

merged 16 commits into from
Apr 17, 2023

Commits on Apr 17, 2023

  1. Work around kill on windows doesn't kill process with shell:true

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    7742ea4 View commit details
    Browse the repository at this point in the history

  2. Proper app teardown

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    c227aa5 View commit details
    Browse the repository at this point in the history

  3. fix windows not able to call taskkill without shell

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ce26727 View commit details
    Browse the repository at this point in the history

  4. Fix bot cleanup process

    @sw-joelmut @OEvgeny
    sw-joelmut authored and OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    8f9e858 View commit details
    Browse the repository at this point in the history

  5. Rework app exit flow

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    82d708c View commit details
    Browse the repository at this point in the history

  6. flushExistingTasks to properly call Promise.all

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    76c8278 View commit details
    Browse the repository at this point in the history

  7. Re-initialize close listeners on app reopened on Mac

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6409ea9 View commit details
    Browse the repository at this point in the history

  8. allow user to hide window while teardown happens

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    da4e56d View commit details
    Browse the repository at this point in the history

  9. Refactor and improve

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e6dd9ce View commit details
    Browse the repository at this point in the history

  10. Do not prevent subsequent attempts to close the main window

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    12eb11e View commit details
    Browse the repository at this point in the history

  11. fix: possible race condition for window recreation on mac

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9480ebb View commit details
    Browse the repository at this point in the history

  12. minor improvements

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    52302e8 View commit details
    Browse the repository at this point in the history

  13. simplify exit logic

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ea3f6f5 View commit details
    Browse the repository at this point in the history

  14. bring back missing destroy call

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    12bb0f9 View commit details
    Browse the repository at this point in the history

  15. fix flaky test

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ca28ae5 View commit details
    Browse the repository at this point in the history

  16. fix lock

    @OEvgeny
    OEvgeny committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    7dfd03b View commit details
    Browse the repository at this point in the history